From: Steve Dickson <steved@redhat.com>
To: Petr Vorel <pvorel@suse.cz>, linux-nfs@vger.kernel.org
Cc: Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH 0/3] Add getrandom() fallback, cleanup headers
Date: Mon, 13 Nov 2023 11:51:31 -0500 [thread overview]
Message-ID: <1360d937-1e54-4841-a40e-07077b8a3506@redhat.com> (raw)
In-Reply-To: <20231025194701.456031-1-pvorel@suse.cz>
On 10/25/23 3:46 PM, Petr Vorel wrote:
> Hi,
>
> motivation to add this is to allow to compile reexport on systems with
> older libc. (getrandom() wrapper is supported on glibc 2.25+ and musl
> 1.1.20+, uclibc-ng does
> not yet support it).
>
> getrandom() syscall is supported Linux 3.17+ (old enough to bother with
> a check).
>
> I also wonder why getrandom() syscall does not called with GRND_NONBLOCK
> flag. Is it ok/needed to block?
>
> Kind regards,
> Petr
>
> Petr Vorel (3):
> reexport/fsidd.c: Remove unused headers
> support/reexport.c: Remove unused headers
> support/backend_sqlite.c: Add getrandom() fallback
>
> Makefile.am | 1 +
> aclocal/getrandom.m4 | 16 ++++++++++++++++
> configure.ac | 3 +++
> support/reexport/backend_sqlite.c | 18 +++++++++++++++++-
> support/reexport/fsidd.c | 10 ----------
> support/reexport/reexport.c | 7 -------
> 6 files changed, 37 insertions(+), 18 deletions(-)
> create mode 100644 aclocal/getrandom.m4
>
Committed... (tag: nfs-utils-2-6-4-rc6)
steved.
prev parent reply other threads:[~2023-11-13 16:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 19:46 [PATCH 0/3] Add getrandom() fallback, cleanup headers Petr Vorel
2023-10-25 19:46 ` [PATCH 1/3] reexport/fsidd.c: Remove unused headers Petr Vorel
2023-10-25 19:47 ` [PATCH 2/3] support/reexport.c: " Petr Vorel
2023-10-25 19:56 ` Richard Weinberger
2023-10-25 19:47 ` [PATCH 3/3] support/backend_sqlite.c: Add getrandom() fallback Petr Vorel
2023-10-25 20:13 ` [PATCH 0/3] Add getrandom() fallback, cleanup headers Richard Weinberger
2023-10-25 20:54 ` Petr Vorel
2023-10-25 20:57 ` Petr Vorel
2023-11-13 16:51 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360d937-1e54-4841-a40e-07077b8a3506@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.