All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH 7/8] drm/tiledc: Remove redundant debugfs cleanup
Date: Sun,  7 Jul 2013 20:02:24 +0100	[thread overview]
Message-ID: <1373223745-9095-7-git-send-email-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <1373223745-9095-1-git-send-email-chris@chris-wilson.co.uk>

All inode removal is handled for us by the core.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Darren Etheridge <detheridge@ti.com>
Cc: Benoit Parrot <bparrot@ti.com>
Cc: Rob Clark <robdclark@gmail.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 12 ------------
 drivers/gpu/drm/tilcdc/tilcdc_drv.h |  2 --
 2 files changed, 14 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 40b71da..c481843 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -474,17 +474,6 @@ static int tilcdc_debugfs_init(struct drm_minor *minor)
 
 	return ret;
 }
-
-static void tilcdc_debugfs_cleanup(struct drm_minor *minor)
-{
-	struct tilcdc_module *mod;
-	drm_debugfs_remove_files(tilcdc_debugfs_list,
-			ARRAY_SIZE(tilcdc_debugfs_list), minor);
-
-	list_for_each_entry(mod, &module_list, list)
-		if (mod->funcs->debugfs_cleanup)
-			mod->funcs->debugfs_cleanup(mod, minor);
-}
 #endif
 
 static const struct file_operations fops = {
@@ -522,7 +511,6 @@ static struct drm_driver tilcdc_driver = {
 	.dumb_destroy       = drm_gem_cma_dumb_destroy,
 #ifdef CONFIG_DEBUG_FS
 	.debugfs_init       = tilcdc_debugfs_init,
-	.debugfs_cleanup    = tilcdc_debugfs_cleanup,
 #endif
 	.fops               = &fops,
 	.name               = "tilcdc",
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h
index 0938036..56fe122 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h
@@ -102,8 +102,6 @@ struct tilcdc_module_ops {
 #ifdef CONFIG_DEBUG_FS
 	/* create debugfs nodes (can be NULL): */
 	int (*debugfs_init)(struct tilcdc_module *mod, struct drm_minor *minor);
-	/* cleanup debugfs nodes (can be NULL): */
-	void (*debugfs_cleanup)(struct tilcdc_module *mod, struct drm_minor *minor);
 #endif
 };
 
-- 
1.8.3.2

  parent reply	other threads:[~2013-07-07 19:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07 19:02 [PATCH 1/8] drm: Clean up debugfs upon shutdown Chris Wilson
2013-07-07 19:02 ` [PATCH 2/8] drm/i915: Remove redundant debugfs cleanup Chris Wilson
2013-07-07 19:02 ` [PATCH 3/8] drm/nouveau: " Chris Wilson
2013-07-07 19:02 ` [PATCH 4/8] drm/omap: " Chris Wilson
2013-07-07 23:40   ` Rob Clark
2013-07-07 19:02 ` [PATCH 5/8] drm/qxl: " Chris Wilson
2013-07-07 19:02 ` [PATCH 6/8] drm/radeon: " Chris Wilson
2013-07-07 19:02 ` Chris Wilson [this message]
2013-07-07 23:40   ` [PATCH 7/8] drm/tiledc: " Rob Clark
2013-07-07 19:02 ` [PATCH 8/8] drm: Remove debugfs_cleanup callback from drivers Chris Wilson
2013-07-08 20:21   ` Daniel Vetter
2013-07-07 23:39 ` [PATCH 1/8] drm: Clean up debugfs upon shutdown Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373223745-9095-7-git-send-email-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.