All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: dmitry.torokhov@gmail.com
Cc: rob.herring@calxeda.com, pawel.moll@arm.com,
	mark.rutland@arm.com, swarren@wwwdotorg.org,
	ijc+devicetree@hellion.org.uk, rob@landley.net,
	bcousson@baylibre.com, Tony Lindgren <tony@atomide.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	devicetree@vger.kernel.org,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	linux-input@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding
Date: Mon, 21 Oct 2013 15:13:23 -0500	[thread overview]
Message-ID: <1382386404-6659-2-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1382386404-6659-1-git-send-email-balbi@ti.com>

There was a spelling mistake on TSC/ADC binding where
"coordinate" was spelled as "coordiante".

We can't simply fix the error due to DT being an ABI,
the approach taken was to first use correct spelling
and if that fails, fallback to miss-spelled version.

It's unfortunate that has creeped into the tree.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt         | 2 +-
 arch/arm/boot/dts/am335x-evm.dts                                 | 2 +-
 drivers/input/touchscreen/ti_am335x_tsc.c                        | 9 ++++++++-
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
index 491c97b..878549b 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
@@ -6,7 +6,7 @@ Required properties:
 	ti,wires: Wires refer to application modes i.e. 4/5/8 wire touchscreen
 		  support on the platform.
 	ti,x-plate-resistance: X plate resistance
-	ti,coordiante-readouts: The sequencer supports a total of 16
+	ti,coordinate-readouts: The sequencer supports a total of 16
 				programmable steps each step is used to
 				read a single coordinate. A single
                                 readout is enough but multiple reads can
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index e8ec875..c5b73bc 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -509,7 +509,7 @@
 	tsc {
 		ti,wires = <4>;
 		ti,x-plate-resistance = <200>;
-		ti,coordiante-readouts = <5>;
+		ti,coordinate-readouts = <5>;
 		ti,wire-config = <0x00 0x11 0x22 0x33>;
 	};
 
diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index e1c5300..b61df9d 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -348,9 +348,16 @@ static int titsc_parse_dt(struct platform_device *pdev,
 	if (err < 0)
 		return err;
 
-	err = of_property_read_u32(node, "ti,coordiante-readouts",
+	/*
+	 * try with new binding first. If it fails, still try with
+	 * bogus, miss-spelled version.
+	 */
+	err = of_property_read_u32(node, "ti,coordinate-readouts",
 			&ts_dev->coordinate_readouts);
 	if (err < 0)
+		err = of_property_read_u32(node, "ti,coordiante-readouts",
+				&ts_dev->coordinate_readouts);
+	if (err < 0)
 		return err;
 
 	return of_property_read_u32_array(node, "ti,wire-config",
-- 
1.8.4.GIT


  reply	other threads:[~2013-10-21 20:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 20:13 [PATCH 0/2] arm: am335x: am335x evm sk: add touchscreen DT node Felipe Balbi
2013-10-21 20:13 ` Felipe Balbi [this message]
2013-10-22  8:42   ` [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding Sebastian Andrzej Siewior
2013-10-22 12:02     ` Felipe Balbi
2013-11-14 11:19       ` Mark Rutland
2013-11-14 15:54         ` Felipe Balbi
2013-11-15 15:55           ` Mark Rutland
2013-11-15 17:53             ` Felipe Balbi
2013-11-18 11:40               ` Mark Rutland
2013-11-18 15:29                 ` [PATCH] input: touchscreen: ti_am335x_tsc: warn about incorrect spelling Felipe Balbi
2013-11-18 15:35                   ` Mark Rutland
2014-06-14  0:23                   ` Felipe Balbi
2014-06-15  7:16                     ` Dmitry Torokhov
2014-06-15 15:55                       ` Felipe Balbi
2013-10-21 20:13 ` [PATCH 2/2] arm: dts: am335x sk: add touchscreen support Felipe Balbi
     [not found] ` <1382386404-6659-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2013-11-11  7:59   ` [PATCH 0/2] arm: am335x: am335x evm sk: add touchscreen DT node Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382386404-6659-2-git-send-email-balbi@ti.com \
    --to=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=bigeasy@linutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=swarren@wwwdotorg.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.