All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dylan Reid <dgreid@chromium.org>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Dylan Reid <dgreid@chromium.org>, swarren@wwwdotorg.org
Subject: [RFCv2 10/22] ALSA: hda - Add pcm_mmap_prepare op.
Date: Fri, 28 Feb 2014 15:41:21 -0800	[thread overview]
Message-ID: <1393630893-29010-11-git-send-email-dgreid@chromium.org> (raw)
In-Reply-To: <1393630893-29010-1-git-send-email-dgreid@chromium.org>

Adding this op allows the X86 specific mmap operation to help in
hda_intel without needing a CONFIG_X86 in future non-PCI hda drivers.

Signed-off-by: Dylan Reid <dgreid@chromium.org>
---
 sound/pci/hda/hda_intel.c | 20 ++++++++++++++------
 sound/pci/hda/hda_priv.h  |  2 ++
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index fa3a04c..aa8b765 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2190,19 +2190,15 @@ static void azx_clear_irq_pending(struct azx *chip)
 	spin_unlock_irq(&chip->reg_lock);
 }
 
-#ifdef CONFIG_X86
 static int azx_pcm_mmap(struct snd_pcm_substream *substream,
 			struct vm_area_struct *area)
 {
 	struct azx_pcm *apcm = snd_pcm_substream_chip(substream);
 	struct azx *chip = apcm->chip;
-	if (!azx_snoop(chip))
-		area->vm_page_prot = pgprot_writecombine(area->vm_page_prot);
+	if (chip->ops->pcm_mmap_prepare)
+		chip->ops->pcm_mmap_prepare(substream, area);
 	return snd_pcm_lib_default_mmap(substream, area);
 }
-#else
-#define azx_pcm_mmap	NULL
-#endif
 
 static struct snd_pcm_ops azx_pcm_ops = {
 	.open = azx_pcm_open,
@@ -3508,6 +3504,17 @@ static int substream_free_pages(struct azx *chip,
 	return snd_pcm_lib_free_pages(substream);
 }
 
+static void pcm_mmap_prepare(struct snd_pcm_substream *substream,
+			     struct vm_area_struct *area)
+{
+#ifdef CONFIG_X86
+	struct azx_pcm *apcm = snd_pcm_substream_chip(substream);
+	struct azx *chip = apcm->chip;
+	if (!azx_snoop(chip))
+		area->vm_page_prot = pgprot_writecombine(area->vm_page_prot);
+#endif
+}
+
 static const struct hda_controller_ops pci_hda_ops = {
 	.writel = pci_azx_writel,
 	.readl = pci_azx_readl,
@@ -3520,6 +3527,7 @@ static const struct hda_controller_ops pci_hda_ops = {
 	.dma_free_pages = dma_free_pages,
 	.substream_alloc_pages = substream_alloc_pages,
 	.substream_free_pages = substream_free_pages,
+	.pcm_mmap_prepare = pcm_mmap_prepare,
 };
 
 static int azx_probe(struct pci_dev *pci,
diff --git a/sound/pci/hda/hda_priv.h b/sound/pci/hda/hda_priv.h
index 10bcec1..edbe2eb 100644
--- a/sound/pci/hda/hda_priv.h
+++ b/sound/pci/hda/hda_priv.h
@@ -309,6 +309,8 @@ struct hda_controller_ops {
 				     size_t size);
 	int (*substream_free_pages)(struct azx *chip,
 				    struct snd_pcm_substream *substream);
+	void (*pcm_mmap_prepare)(struct snd_pcm_substream *substream,
+				 struct vm_area_struct *area);
 };
 
 struct azx_pcm {
-- 
1.8.1.3.605.g02339dd

  parent reply	other threads:[~2014-02-28 23:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 23:41 [RFC 00/19] Enable platform HDA drivers Dylan Reid
2014-02-28 23:41 ` [RFCv2 01/22] ALSA: hda - Move some definitions to new hda_priv.h Dylan Reid
2014-02-28 23:41 ` [RFCv2 02/22] ALSA: hda - Allow different ops to read/write registers Dylan Reid
2014-02-28 23:41 ` [RFCv2 03/22] ALSA: hda - Keep pointer to bdl_pos_fix in chip struct Dylan Reid
2014-02-28 23:41 ` [RFCv2 04/22] ALSA: hda - Use device pointer from the card instead of pci Dylan Reid
2014-02-28 23:41 ` [RFCv2 05/22] ALSA: hda - Add function pointer for disabling MSI Dylan Reid
2014-02-28 23:41 ` [RFCv2 06/22] ALSA: hda - remove unused clear of STATESTS Dylan Reid
2014-02-28 23:41 ` [RFCv2 07/22] ALSA: hda - Add jackpoll_ms to struct azx Dylan Reid
2014-02-28 23:41 ` [RFCv2 08/22] ALSA: hda - Pass max_slots and power_save to codec_create Dylan Reid
2014-02-28 23:41 ` [RFCv2 09/22] ALSA: hda - Move snd page allocation to ops Dylan Reid
2014-02-28 23:41 ` Dylan Reid [this message]
2014-02-28 23:41 ` [RFCv2 11/22] ALSA: hda - Add hda_controller.c and move pcm ops from hda_intel Dylan Reid
2014-02-28 23:41 ` [RFCv2 12/22] ALSA: hda - Pull pages allocation to hda_controller Dylan Reid
2014-02-28 23:41 ` [RFCv2 13/22] ALSA: hda - Move the dsp loader " Dylan Reid
2014-02-28 23:41 ` [RFCv2 14/22] ALSA: hda - Relocate RIRB/CORB interface " Dylan Reid
2014-02-28 23:41 ` [RFCv2 15/22] ALSA: hda - move alloc_cmd_io " Dylan Reid
2014-02-28 23:41 ` [RFCv2 16/22] ALSA: hda - Move low level functions " Dylan Reid
2014-02-28 23:41 ` [RFCv2 17/22] ALSA: hda - Add position_check op Dylan Reid
2014-02-28 23:41 ` [RFCv2 18/22] ALSA: hda - Move azx_interrupt to hda_controller Dylan Reid
2014-02-28 23:41 ` [RFCv2 19/22] ALSA: hda - Move codec create " Dylan Reid
2014-02-28 23:41 ` [RFCv2 20/22] ALSA: core - Define snd_pci_quirk without CONFIG_PCI Dylan Reid
2014-02-28 23:41 ` [RFCv2 21/22] ALSA: hda - remove PCI dependency in Kconfig Dylan Reid
2014-02-28 23:41 ` [RFCv2 22/22] WIP: ALSA: hda - Add driver for Tegra SoC HDA Dylan Reid
2014-03-01  9:07 ` [RFC 00/19] Enable platform HDA drivers Takashi Iwai
2014-03-01  9:37   ` Dylan Reid
2014-03-01 10:42     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393630893-29010-11-git-send-email-dgreid@chromium.org \
    --to=dgreid@chromium.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.