From: John Clark <inindev@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b
Date: Mon, 25 Dec 2023 05:51:33 -0500 [thread overview]
Message-ID: <13a83ffa-f0e3-4afb-1701-cd6c8fdf8031@gmail.com> (raw)
In-Reply-To: <576f22ba-c8c2-4796-8226-aee8a1d9d57b@linaro.org>
On 12/25/23 5:43 AM, Krzysztof Kozlowski wrote:
> On 25/12/2023 11:20, John Clark wrote:
>> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on
>> the rock-5b it reboots instead. Using the 'system-power-controller' allows
>> the rk806 to power down instead.
>>
>> Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this
>> issue for the nanopc-t6.
> That's not the syntax I asked for. Where is its subject? Syntax is:
> commit foo ("subject"), respecting the length of SHA, as checked by
> checkpatch.
>
> You still miss v2 and changelog. I also wrote about this. b4 does it for
> you, but if you decide to use git manually, then you have to add it.
>
> Best regards,
> Krzysztof
>
The documentation for --in-reply-to=<identifier> clearly states that it
will generate the v2 semantics for the subject, yet it did not. I used
the message-id from the first message since it was a two email patch to
begin with. It is not clear to me why this did not happen. I will see
if I can find a sandbox to practice my get-send-email skills in.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-12-25 10:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-25 9:08 [PATCH 1/2] arm64: dts: rockchip: support poweroff on rock-5b John Clark
2023-12-25 9:08 ` [PATCH 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo John Clark
2023-12-25 9:19 ` Krzysztof Kozlowski
2023-12-25 9:19 ` [PATCH 1/2] arm64: dts: rockchip: support poweroff on rock-5b Krzysztof Kozlowski
2023-12-25 9:26 ` John Clark
2023-12-25 9:30 ` Krzysztof Kozlowski
2023-12-25 10:20 ` [PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b John Clark
2023-12-25 10:20 ` [PATCH 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo John Clark
2023-12-25 10:43 ` [PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b Krzysztof Kozlowski
2023-12-25 10:51 ` John Clark [this message]
2023-12-25 11:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a83ffa-f0e3-4afb-1701-cd6c8fdf8031@gmail.com \
--to=inindev@gmail.com \
--cc=conor+dt@kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.