All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: linux-pm@vger.kernel.org
Cc: rafael.j.wysocki@intel.com, anton@enomsg.org,
	Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH 0/4] fix spurious wake from suspend to freeze caused by ACPI battery driver
Date: Wed, 28 May 2014 15:23:34 +0800	[thread overview]
Message-ID: <1401261818-2978-1-git-send-email-rui.zhang@intel.com> (raw)

Hi, all,

There is a bug report complaining about spurious wake from suspend to freeze.
And I can reproduce the problem on a Toshiba PORTEGE Z830 ultrabook.
https://bugzilla.kernel.org/show_bug.cgi?id=76221

The root cause is that,
1. ACPI battery device receives an ACPI notification about battery remaining
capacity change every 10 seconds.
2. commit 948dcf96622814d2a850a12851d27824530a9747 registers a wakeup source
for every power supply device, to prevent the system from sleeping when there
is a power supply event.

And this results in that the ACPI notification wakes the system up from
suspend-to-freeze shortly.

As ACPI battery driver has the knowledge of whether an important battery change
happens, e.g. battery remaining capacity critical low, etc, it is reasonable
to have its own wakeup source and wakeup the system only when necessary.
And this patch set is made to fix the problem in this way.

Any comments are welcome.

thanks,
rui

             reply	other threads:[~2014-05-28  7:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-28  7:23 Zhang Rui [this message]
2014-05-28  7:23 ` [PATCH 1/4] PM: unregister the wakeup source when disabling a device' wakeup capability Zhang Rui
2014-05-28  7:23 ` [PATCH 2/4] ACPI battery: introduce support for POWER_SUPPLY_PROP_CAPACITY_LEVEL Zhang Rui
2014-05-28  7:23 ` [PATCH 3/4] Power_supply: allow power supply devices registered w/o wakeup source Zhang Rui
2014-05-28  7:23 ` [PATCH 4/4] ACPI battery: wakeup the system only when necessary Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401261818-2978-1-git-send-email-rui.zhang@intel.com \
    --to=rui.zhang@intel.com \
    --cc=anton@enomsg.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.