Re: [PATCH v2 2/2] earlycon: Let users set the clock frequency

From: Jiri Slaby <jirislaby@kernel.org>
To: Ricardo Ribalda <ribalda@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] earlycon: Let users set the clock frequency
Date: Thu, 24 Nov 2022 12:19:28 +0100	[thread overview]
Message-ID: <140187ba-7d2c-8b7b-e172-7350eed458be@kernel.org> (raw)
In-Reply-To: <20221123-serial-clk-v2-2-9c03ce8940d8@chromium.org>

Hi,

On 24. 11. 22, 11:02, Ricardo Ribalda wrote:
...
> --- a/drivers/tty/serial/earlycon.c
> +++ b/drivers/tty/serial/earlycon.c
> @@ -120,9 +120,15 @@ static int __init parse_options(struct earlycon_device *device, char *options)
>   	}
>   
>   	if (options) {
> +		char *uartclk;
> +
>   		if (kstrtouint(options, 0, &device->baud) < 0)
>   			pr_warn("[%s] unsupported earlycon baud rate option\n",
>   				options);

IMO this won't work if there is a comma in options (i.e. your new 
clkrate param). kstrtouint will return -EINVAL in that case.

> +		uartclk = strchr(options, ',');
> +		if (uartclk && kstrtouint(uartclk, 0, &port->uartclk) < 0)

You are giving ",number" to kstrtouint, right? That won't work either ;).

regards,
-- 
js