From: Kiran Padwal <kiran.padwal@smartplayin.com>
To: davidb@codeaurora.org
Cc: dwalker@fifo99.com, bryanh@codeaurora.org, sboyd@codeaurora.org,
gregkh@linuxfoundation.org, jslaby@suse.cz,
kiran.padwal@smartplayin.com, linux-arm-msm@vger.kernel.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] tty: serial: msm: Fix 'Missing a blank line after declarations' warning
Date: Tue, 5 Aug 2014 13:22:00 +0530 [thread overview]
Message-ID: <1407225124-25074-3-git-send-email-kiran.padwal@smartplayin.com> (raw)
In-Reply-To: <1407225124-25074-1-git-send-email-kiran.padwal@smartplayin.com>
This patch fixes below checkpatch.pl warning and it remove extra blank lines:
WARNING: Missing a blank line after declarations
Signed-off-by: Kiran Padwal <kiran.padwal@smartplayin.com>
---
drivers/tty/serial/msm_serial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 6c7300b..0295493 100644
--- a/drivers/tty/serial/msm_serial.c
+++ b/drivers/tty/serial/msm_serial.c
@@ -314,7 +314,6 @@ static unsigned int msm_get_mctrl(struct uart_port *port)
return TIOCM_CAR | TIOCM_CTS | TIOCM_DSR | TIOCM_RTS;
}
-
static void msm_reset(struct uart_port *port)
{
struct msm_port *msm_port = UART_TO_MSM(port);
@@ -335,6 +334,7 @@ static void msm_reset(struct uart_port *port)
static void msm_set_mctrl(struct uart_port *port, unsigned int mctrl)
{
unsigned int mr;
+
mr = msm_read(port, UART_MR1);
if (!(mctrl & TIOCM_RTS)) {
@@ -430,7 +430,6 @@ static int msm_set_baud_rate(struct uart_port *port, unsigned int baud)
return baud;
}
-
static void msm_init_clock(struct uart_port *port)
{
struct msm_port *msm_port = UART_TO_MSM(port);
@@ -645,6 +644,7 @@ fail_release_port:
static void msm_config_port(struct uart_port *port, int flags)
{
int ret;
+
if (flags & UART_CONFIG_TYPE) {
port->type = PORT_MSM;
ret = msm_request_port(port);
--
1.7.9.5
next prev parent reply other threads:[~2014-08-05 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 7:51 [PATCH 0/5] tty: serial: msm: Fix checkpatch errors Kiran Padwal
2014-08-05 7:51 ` [PATCH 1/5] tty: serial: msm: remove braces {} in msm_serial.c Kiran Padwal
2014-08-05 7:52 ` Kiran Padwal [this message]
2014-08-05 7:52 ` [PATCH 3/5] tty: serial: msm: Fix style warnings relating to printk() Kiran Padwal
2014-08-05 7:52 ` [PATCH 4/5] tty: serial: msm: Fix 'else is not generally useful after a break or return' warning Kiran Padwal
2014-08-05 7:52 ` [PATCH 5/5] tty: serial: msm: Fix 'void function return statements are not generally useful' warning Kiran Padwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407225124-25074-3-git-send-email-kiran.padwal@smartplayin.com \
--to=kiran.padwal@smartplayin.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.