From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 05/10] spi: dw: disable all interrupts first when pump message
Date: Wed, 24 Sep 2014 13:38:17 +0300 [thread overview]
Message-ID: <1411555097.30231.14.camel@linux.intel.com> (raw)
In-Reply-To: <20140924084724.GH4015-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Wed, 2014-09-24 at 09:47 +0100, Mark Brown wrote:
> On Thu, Sep 18, 2014 at 08:08:55PM +0300, Andy Shevchenko wrote:
>
> > Always disable all interrupts before pump message. Enable them only for PIO
> > mode.
>
> Why?
>
> It's also not very obvious looking at the diff how this actually works,
> the connection between DMA based transfer and interrupt disabling is
> not clear.
It's a really good question and needs to be investigated more.
If I don't disable interrupts I'm getting sometimes overrun/underrun
interrupt. But we have no proper transfer handler in case of DMA.
Perhaps we should carefully handle that case.
--
Andy Shevchenko <andriy.shevchenko-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-24 10:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 17:08 [PATCH 00/10] spi: dw: make DMA working Andy Shevchenko
[not found] ` <1411060140-2801-1-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-18 17:08 ` [PATCH 01/10] spi: dw-mid: respect 8 bit mode Andy Shevchenko
[not found] ` <1411060140-2801-2-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-24 8:49 ` Mark Brown
2014-09-18 17:08 ` [PATCH 02/10] spi: dw-mid: always use duplex transfers when DMA Andy Shevchenko
[not found] ` <1411060140-2801-3-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-24 8:44 ` Mark Brown
[not found] ` <20140924084407.GF4015-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-24 10:32 ` Andy Shevchenko
[not found] ` <1411554747.30231.10.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-24 11:07 ` Mark Brown
[not found] ` <20140924110747.GG16977-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-24 12:02 ` Andy Shevchenko
2014-09-18 17:08 ` [PATCH 03/10] spi: dw-mid: terminate ongoing transfers at exit Andy Shevchenko
[not found] ` <1411060140-2801-4-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-24 8:49 ` Mark Brown
2014-09-18 17:08 ` [PATCH 04/10] spi: dw-mid: follow new DMAengine workflow Andy Shevchenko
[not found] ` <1411060140-2801-5-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-24 8:44 ` Mark Brown
[not found] ` <20140924084453.GG4015-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-24 10:35 ` Andy Shevchenko
[not found] ` <1411554938.30231.12.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-24 11:08 ` Mark Brown
[not found] ` <20140924110849.GH16977-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-24 11:59 ` Andy Shevchenko
2014-09-18 17:08 ` [PATCH 05/10] spi: dw: disable all interrupts first when pump message Andy Shevchenko
[not found] ` <1411060140-2801-6-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-24 8:47 ` Mark Brown
[not found] ` <20140924084724.GH4015-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-24 10:38 ` Andy Shevchenko [this message]
2014-09-18 17:08 ` [PATCH 06/10] spi: dw: introduce support of loopback mode Andy Shevchenko
[not found] ` <1411060140-2801-7-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-24 8:49 ` Mark Brown
2014-09-18 17:08 ` [PATCH 07/10] spi: dw: fix style of code in few places Andy Shevchenko
[not found] ` <1411060140-2801-8-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-24 8:50 ` Mark Brown
2014-09-18 17:08 ` [PATCH 08/10] spi: dw-mid: move to use core SPI DMA mappings Andy Shevchenko
2014-09-18 17:08 ` [PATCH 09/10] spi: dw-mid: convert to use dw_dmac instead of intel_mid_dma Andy Shevchenko
2014-09-18 17:09 ` [PATCH 10/10] dmaengine: intel-mid-dma: remove the driver Andy Shevchenko
[not found] ` <1411060140-2801-11-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-10-15 15:07 ` Vinod Koul
[not found] ` <20141015150727.GX1638-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-16 8:12 ` Shevchenko, Andriy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411555097.30231.14.camel@linux.intel.com \
--to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.