All of lore.kernel.org
 help / color / mirror / Atom feed
From: Varka Bhadram <varkabhadram@gmail.com>
To: netdev@vger.kernel.org
Cc: Varka Bhadram <varkab@cdac.in>
Subject: [PATCH net-next 5/6] ethernet: renesas: remove unnecessary check
Date: Wed, 22 Oct 2014 09:46:25 +0530	[thread overview]
Message-ID: <1413951386-29645-6-git-send-email-varkab@cdac.in> (raw)
In-Reply-To: <1413951386-29645-1-git-send-email-varkab@cdac.in>

devm_ioremap_resource checks platform_get_resource() return value.
We can remove the duplicate check here.

Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
 drivers/net/ethernet/renesas/sh_eth.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 60e9c2c..d824ba5 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -2769,10 +2769,6 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
 
 	/* get base addr */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (unlikely(res == NULL)) {
-		dev_err(&pdev->dev, "invalid resource\n");
-		return -EINVAL;
-	}
 
 	ndev = alloc_etherdev(sizeof(struct sh_eth_private));
 	if (!ndev)
-- 
1.7.9.5

  parent reply	other threads:[~2014-10-22  4:19 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <N>
2012-11-22 11:54 ` [PATCH 1/2] fs/buffer.c: do not inline exported function Yan Hong
2012-11-22 11:54   ` [PATCH 2/2] fs/buffer.c: remove redundant initialization in alloc_page_buffers() Yan Hong
2014-02-12 10:06 ` [PATCH v2] NFSv4.1: new layout stateid can not be overwrite by one out of date shaobingqing
2014-02-12 12:34   ` Trond Myklebust
2014-02-17  7:08 ` [PATCH v3] " shaobingqing
2014-02-17 16:46   ` Trond Myklebust
2014-07-11 10:35 ` [PATCH 1/2] f2fs: cleanup the needless return of f2fs_create_root_stats Gu Zheng
2014-07-11 10:35   ` [PATCH 2/2] f2fs: remove the unused stat_lock Gu Zheng
2014-10-22  4:16 ` [PATCH net-next 0/6] cleanup on resource check Varka Bhadram
2014-10-22  4:16   ` [PATCH net-next 1/6] ethernet: wiznet: remove unnecessary check Varka Bhadram
2014-10-22 11:43     ` Sergei Shtylyov
2014-10-22 12:23       ` Varka Bhadram
2014-10-22  4:16   ` [PATCH net-next 2/6] " Varka Bhadram
2014-10-22 11:44     ` Sergei Shtylyov
2014-10-22 12:24       ` Varka Bhadram
2014-10-22  4:16   ` [PATCH net-next 3/6] ethernet: apm: xgene: " Varka Bhadram
2014-10-22  4:16   ` [PATCH net-next 4/6] ethernet: marvell: " Varka Bhadram
2014-10-22  4:16   ` Varka Bhadram [this message]
2014-10-22 11:47     ` [PATCH net-next 5/6] ethernet: renesas: " Sergei Shtylyov
2014-10-22 12:22       ` Varka Bhadram
2014-10-22  4:16   ` [PATCH net-next 6/6] ethernet: samsung: sxgbe: " Varka Bhadram
2014-11-04  1:47 ` [PATCH usb v4 0/2] fixes on resource check varkabhadram
2014-11-04  1:47   ` [PATCH usb v4 1/2] host: uhci-platform: fix NULL pointer dereference on resource varkabhadram
2014-11-04  1:47   ` [PATCH usb v4 2/2] host: ehci-sead3: " varkabhadram
2020-08-18 15:20 ` [RFC PATCH 00/30] ima: Introduce IMA namespace krzysztof.struczynski
2020-08-18 15:20   ` [RFC PATCH 01/30] ima: Introduce ima namespace krzysztof.struczynski
2020-08-18 15:20   ` [RFC PATCH 02/30] ima: Add a list of the installed ima namespaces krzysztof.struczynski
2020-08-18 15:20   ` [RFC PATCH 03/30] ima: Bind ima namespace to the file descriptor krzysztof.struczynski
2020-08-18 15:20   ` [RFC PATCH 04/30] ima: Add ima policy related data to the ima namespace krzysztof.struczynski
2020-08-18 15:20   ` [RFC PATCH 05/30] ima: Add methods for parsing ima policy configuration string krzysztof.struczynski
2020-08-18 15:20   ` [RFC PATCH 06/30] ima: Add ima namespace to the ima subsystem APIs krzysztof.struczynski
2020-08-18 15:20   ` [RFC PATCH 07/30] ima: Extend the APIs in the integrity subsystem krzysztof.struczynski
2020-08-18 15:20   ` [RFC PATCH 08/30] ima: Add integrity inode related data to the ima namespace krzysztof.struczynski
2020-08-18 15:20   ` [RFC PATCH 09/30] ima: Enable per ima namespace policy settings krzysztof.struczynski
2020-08-18 15:53   ` [RFC PATCH 00/30] ima: Introduce IMA namespace Christian Brauner
2020-08-21 15:18     ` Krzysztof Struczynski
2020-08-18 16:19   ` James Bottomley
2020-08-21 15:13     ` Krzysztof Struczynski
2020-09-02 18:53       ` Mimi Zohar
2020-09-02 18:53         ` Mimi Zohar
2020-09-04 14:06         ` Dr. Greg
2020-09-04 14:06           ` Dr. Greg
2020-09-14 12:05         ` Krzysztof Struczynski
2020-09-14 12:05           ` Krzysztof Struczynski
2020-08-18 16:49   ` Christian Brauner
2020-08-21 15:37     ` Krzysztof Struczynski
2020-09-02 19:54     ` Mimi Zohar
2020-09-02 19:54       ` Mimi Zohar
2020-09-06 17:14       ` Dr. Greg
2020-09-06 17:14         ` Dr. Greg
2020-09-07 11:50         ` Luke Hinds
2020-09-08 14:03           ` Mimi Zohar
2020-09-08 14:03             ` Mimi Zohar
2020-09-14 12:07             ` Krzysztof Struczynski
2020-09-14 12:07               ` Krzysztof Struczynski
2020-10-19  9:30             ` Krzysztof Struczynski
2020-10-19  9:30               ` Krzysztof Struczynski
2020-10-25 15:00               ` Dr. Greg
2020-10-25 15:00                 ` Dr. Greg
2020-09-09 10:11           ` Dr. Greg
2020-09-09 10:11             ` Dr. Greg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413951386-29645-6-git-send-email-varkab@cdac.in \
    --to=varkabhadram@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=varkab@cdac.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.