All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Nan <wangnan0@huawei.com>
To: <jolsa@redhat.com>, <rostedt@goodmis.org>
Cc: <jeremie.galarneau@efficios.com>, <bigeasy@linutronix.de>,
	<lizefan@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH RFC 1/2] tools lib traceevent: add priv field to truct format_field.
Date: Thu, 22 Jan 2015 13:36:32 +0800	[thread overview]
Message-ID: <1421904992-24189-1-git-send-email-wangnan0@huawei.com> (raw)
In-Reply-To: <1421904958-24106-1-git-send-email-wangnan0@huawei.com>

In https://lkml.org/lkml/2015/1/21/383 , Jiri Olsa gives a suggestion
about changing lib traceevent to solve a bug of perf-convert-to-ctf,
which is related to duplicated field names. I think his suggestion
should be something like this patch.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
---
 tools/lib/traceevent/event-parse.c | 2 ++
 tools/lib/traceevent/event-parse.h | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index cf3a44b..5f76003 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -5909,6 +5909,8 @@ static void free_format_fields(struct format_field *field)
 		free(field->type);
 		free(field->name);
 		free(field);
+		if (field->destroy_priv)
+			field->destroy_priv(field);
 		field = next;
 	}
 }
diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
index 7a3873f..928d801 100644
--- a/tools/lib/traceevent/event-parse.h
+++ b/tools/lib/traceevent/event-parse.h
@@ -190,6 +190,8 @@ struct format_field {
 	unsigned int		arraylen;
 	unsigned int		elementsize;
 	unsigned long		flags;
+	void			*priv;
+	void 			(*destroy_priv)(struct format_field *);
 };
 
 struct format {
-- 
1.8.4


  reply	other threads:[~2015-01-22  5:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 11:07 [PATCH 0/2] perf: convert: two patches for converting syscall tracepoitns Wang Nan
2015-01-20 11:07 ` [PATCH 1/2] perf: convert: fix duplicate field names Wang Nan
2015-01-20 13:06   ` Jiri Olsa
2015-01-21  3:23     ` [PATCH 1/2] perf: convert: fix duplicate field names and avoid reserved keywords Wang Nan
2015-01-21 11:16       ` Wang Nan
2015-01-21 14:19         ` Jiri Olsa
2015-01-21 14:25           ` Steven Rostedt
2015-01-21 14:32             ` Jiri Olsa
2015-01-22  5:35               ` [PATCH RFC 0/2] tools lib traceevent: introduces priv field to struct format_field Wang Nan
2015-01-22  5:36                 ` Wang Nan [this message]
2015-01-22  5:36                 ` [PATCH RFC 2/2] perf: convert: fix duplicate field names and avoid reserved keywords Wang Nan
2015-01-22 13:27                   ` Jiri Olsa
2015-01-23  1:57                     ` Wang Nan
2015-01-23  2:53                       ` Wang Nan
2015-01-23  8:44                         ` Jiri Olsa
2015-01-23  8:45                       ` Jiri Olsa
2015-01-23 22:40                       ` Jérémie Galarneau
2015-01-24 16:39                         ` Jiri Olsa
2015-01-26 11:11                           ` Wang Nan
2015-01-21 14:11       ` [PATCH 1/2] " Jiri Olsa
2015-01-21 15:56         ` Jérémie Galarneau
2015-01-22  1:38           ` Wang Nan
2015-01-22  3:14             ` Jérémie Galarneau
2015-01-22  3:21               ` Wang Nan
2015-01-23 20:45               ` Mathieu Desnoyers
2015-01-20 11:07 ` [PATCH 2/2] perf: convert: fix signess of value Wang Nan
2015-01-20 13:06 ` [PATCH 0/2] perf: convert: two patches for converting syscall tracepoitns Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421904992-24189-1-git-send-email-wangnan0@huawei.com \
    --to=wangnan0@huawei.com \
    --cc=bigeasy@linutronix.de \
    --cc=jeremie.galarneau@efficios.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.