All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: [PATCH 0/5] i915 fb modifier support, respun
Date: Mon,  9 Feb 2015 19:03:23 +0100	[thread overview]
Message-ID: <1423505008-15515-1-git-send-email-daniel.vetter@ffwll.ch> (raw)

Hi all,

So this is the very quickly spun together version for my take on fb modifiers.
Aim is to reduce the churn a bit with:
- Only validate fb modifiers and old tiling_mode behaviour in framebuffer_init
  to ensure they are consistent. Don't convert over all the code for old
  platforms.
- Guarantee that X-tiling always implies that the underlying bo is fenced with
  X-tiling mode, too. Otherwise the implications into existing code (e.g.
  adjusting fbc) are a bit too much.
- One draft patch to show how I think we should us fb modifiers: Directly switch
  on them like we do with obj->tiling_mode, no need to have remap/masking
  functions around. At least for now.

This isn't complete since some of the shared code, specifically the fb_align
stuff used by framebuffer_init and the fbdev emulation code still uses
obj->tiling_mode. That needs to be converted into a function which takes u64 fb
modifers (for shared code) and the old code retained in an i9xx_ variant (for
the plane_config readout code for old platforms). Then we can add the skl+ stuff
in another version, together with a if/else.

And then framebuffer_init obvsiouly needs to be extended.

Commments highly welcome.

Cheers, Daniel

Daniel Vetter (3):
  drm/i915: Add fb format modifier support
  drm/i915: Use fb format modifiers in skylake_update_primary_plane
  drm: Also check unused fields for addfb2

Tvrtko Ursulin (2):
  drm/i915: Add tiled framebuffer modifiers
  drm/i915: Announce support for framebuffer modifiers

 drivers/gpu/drm/drm_crtc.c           | 17 +++++++++++++++++
 drivers/gpu/drm/i915/i915_drv.h      |  1 +
 drivers/gpu/drm/i915/intel_display.c | 32 ++++++++++++++++++++++++--------
 include/uapi/drm/drm_fourcc.h        | 31 +++++++++++++++++++++++++++++++
 4 files changed, 73 insertions(+), 8 deletions(-)

-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-02-09 18:03 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 18:03 Daniel Vetter [this message]
2015-02-09 18:03 ` [PATCH 1/5] drm/i915: Add tiled framebuffer modifiers Daniel Vetter
2015-02-10 11:05   ` Tvrtko Ursulin
2015-02-10 11:28   ` [PATCH] " Daniel Vetter
2015-02-10 16:16     ` shuang.he
2015-02-10 11:50   ` [PATCH] drm/i915: Add fb format modifier support Daniel Vetter
2015-02-09 18:03 ` [PATCH 2/5] " Daniel Vetter
2015-02-10 11:09   ` Tvrtko Ursulin
2015-02-10 11:28   ` [PATCH] " Daniel Vetter
2015-02-09 18:03 ` [PATCH 3/5] drm/i915: Use fb format modifiers in skylake_update_primary_plane Daniel Vetter
2015-02-10 16:25   ` Damien Lespiau
2015-02-09 18:03 ` [PATCH 4/5] drm/i915: Announce support for framebuffer modifiers Daniel Vetter
2015-02-09 18:03 ` [PATCH 5/5] drm: Also check unused fields for addfb2 Daniel Vetter
2015-02-10 10:56   ` [PATCH 1/2] drm/i915: Set up fb format modifier for initial plane config Daniel Vetter
2015-02-10 10:56     ` [PATCH 2/2] drm/i915: Switch +intel_fb_align_height to fb format modifiers Daniel Vetter
2015-02-10 11:01   ` [PATCH 5/5] drm: Also check unused fields for addfb2 Chris Wilson
2015-02-10 11:36     ` Daniel Vetter
2015-02-10 11:51       ` Chris Wilson
2015-02-10 17:16 ` [PATCH v2 00/13] i915 fb modifier support, respun Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 01/13] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 02/13] drm/i915: Add tiled framebuffer modifiers Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 03/13] drm/i915: Add fb format modifier support Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 04/13] drm/i915: Show frame buffer modifier in debug info Tvrtko Ursulin
2015-02-11  7:34     ` Daniel Vetter
2015-02-10 17:16   ` [PATCH 05/13] drm: Also check unused fields for addfb2 Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 06/13] drm/i915: Set up fb format modifier for initial plane config Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 07/13] drm/i915: Switch +intel_fb_align_height to fb format modifiers Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 08/13] drm/i915: Use fb format modifiers in skylake_update_primary_plane Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 09/13] drm/i915/skl: CS flips are not supported with execlists Tvrtko Ursulin
2015-02-11  7:40     ` Daniel Vetter
2015-02-11  9:58       ` Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 10/13] drm/i915/skl: Use fb modifiers for sprites Tvrtko Ursulin
2015-02-11  7:47     ` Daniel Vetter
2015-02-10 17:16   ` [PATCH 11/13] drm/i915: Use fb modifiers in intel_check_cursor_plane Tvrtko Ursulin
2015-02-11  7:53     ` Daniel Vetter
2015-02-10 17:16   ` [PATCH 12/13] drm/i915: Use fb modifiers in intel_pin_and_fence_fb_obj Tvrtko Ursulin
2015-02-10 17:16   ` [PATCH 13/13] drm/i915: Announce support for framebuffer modifiers Tvrtko Ursulin
2015-02-11  2:46     ` shuang.he
2015-02-11  7:56       ` Daniel Vetter
2015-02-11  7:58     ` Daniel Vetter
2015-02-11  9:57       ` Tvrtko Ursulin
2015-02-11 10:25         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423505008-15515-1-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.