All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@poochiereds.net>
To: bfields@fieldses.org
Cc: trond.myklebust@primarydata.com, hch@infradead.org,
	linux-nfs@vger.kernel.org
Subject: [PATCH 2/3] nfsd: remove bogus setting of status in nfsd4_process_open2
Date: Mon, 23 Mar 2015 10:53:43 -0400	[thread overview]
Message-ID: <1427122424-8078-3-git-send-email-jeff.layton@primarydata.com> (raw)
In-Reply-To: <1427122424-8078-1-git-send-email-jeff.layton@primarydata.com>

status is always reset after this (and it doesn't make much sense there
anyway).

Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
---
 fs/nfsd/nfs4state.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index cf29d1a698b3..a66e297dc01c 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4049,7 +4049,6 @@ nfsd4_process_open2(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nf
 		status = nfserr_bad_stateid;
 		if (nfsd4_is_deleg_cur(open))
 			goto out;
-		status = nfserr_jukebox;
 	}
 
 	/*
-- 
2.1.0


  parent reply	other threads:[~2015-03-23 14:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 14:53 [PATCH 0/3] nfsd: fix use-after-free oops in v4.0 (and some other minor cleanups) Jeff Layton
2015-03-23 14:53 ` [PATCH 1/3] nfsd: return correct openowner when there is a race to put one in the hash Jeff Layton
2015-03-23 15:36   ` J. Bruce Fields
2015-03-23 15:45     ` Jeff Layton
2015-03-25  8:45   ` Christoph Hellwig
2015-03-25 10:28     ` Jeff Layton
2015-03-25 13:51       ` Christoph Hellwig
2015-03-23 14:53 ` Jeff Layton [this message]
2015-03-25  8:45   ` [PATCH 2/3] nfsd: remove bogus setting of status in nfsd4_process_open2 Christoph Hellwig
2015-03-23 14:53 ` [PATCH 3/3] nfsd: remove unused status arg to nfsd4_cleanup_open_state Jeff Layton
2015-03-25  8:47   ` Christoph Hellwig
2015-03-23 15:12 ` [PATCH 0/3] nfsd: fix use-after-free oops in v4.0 (and some other minor cleanups) J. Bruce Fields
2015-03-23 15:30   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427122424-8078-3-git-send-email-jeff.layton@primarydata.com \
    --to=jlayton@poochiereds.net \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.