All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Vinod Koul <vinod.koul@intel.com>, Jeeja KP <jeeja.kp@intel.com>,
	Liam Girdwood <liam.r.girdwood@intel.com>
Subject: [PATCH 05/16] ALSA: hda - Merge codec and controller helpers
Date: Thu, 16 Apr 2015 18:14:19 +0200	[thread overview]
Message-ID: <1429200870-5288-6-git-send-email-tiwai@suse.de> (raw)
In-Reply-To: <1429200870-5288-1-git-send-email-tiwai@suse.de>

There is no much merit to keep the HD-audio codec and controller
helper codes in separate modules any longer.  Let's merge them into a
single helper module.

This patch just changes Makefile entries to merge two individual
modules to one.  The only code change is the removal of superfluous
MODULE_*() macros in one side.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/Makefile         | 3 +--
 sound/pci/hda/hda_controller.c | 3 ---
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/pci/hda/Makefile b/sound/pci/hda/Makefile
index af78fb33a4fd..c5e6651efb49 100644
--- a/sound/pci/hda/Makefile
+++ b/sound/pci/hda/Makefile
@@ -1,10 +1,10 @@
 snd-hda-intel-objs := hda_intel.o
-snd-hda-controller-objs := hda_controller.o
 snd-hda-tegra-objs := hda_tegra.o
 # for haswell power well
 snd-hda-intel-$(CONFIG_SND_HDA_I915) +=	hda_i915.o
 
 snd-hda-codec-y := hda_bind.o hda_codec.o hda_jack.o hda_auto_parser.o hda_sysfs.o
+snd-hda-codec-y += hda_controller.o
 snd-hda-codec-$(CONFIG_PROC_FS) += hda_proc.o
 snd-hda-codec-$(CONFIG_SND_HDA_HWDEP) += hda_hwdep.o
 snd-hda-codec-$(CONFIG_SND_HDA_INPUT_BEEP) += hda_beep.o
@@ -27,7 +27,6 @@ snd-hda-codec-hdmi-objs :=	patch_hdmi.o hda_eld.o
 
 # common driver
 obj-$(CONFIG_SND_HDA) := snd-hda-codec.o
-obj-$(CONFIG_SND_HDA) += snd-hda-controller.o
 
 # codec drivers
 obj-$(CONFIG_SND_HDA_GENERIC) += snd-hda-codec-generic.o
diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
index b4474e27631d..6b39f2e8c820 100644
--- a/sound/pci/hda/hda_controller.c
+++ b/sound/pci/hda/hda_controller.c
@@ -1966,6 +1966,3 @@ int azx_init_stream(struct azx *chip)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(azx_init_stream);
-
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("Common HDA driver functions");
-- 
2.3.5

  parent reply	other threads:[~2015-04-16 16:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16 16:14 [PATCH 00/16] HD-audio core controller split Takashi Iwai
2015-04-16 16:14 ` [PATCH 01/16] ALSA: hda - Handle error from get_response bus ops directly Takashi Iwai
2015-04-16 16:14 ` [PATCH 02/16] ALSA: hda - Add the controller helper codes to hda-core module Takashi Iwai
2015-04-16 16:14 ` [PATCH 03/16] ALSA: hda - Add DSP loader to core library code Takashi Iwai
2015-04-16 16:14 ` [PATCH 04/16] ALSA: hda - moved alloc/free stream pages function to controller library Takashi Iwai
2015-04-16 16:14 ` Takashi Iwai [this message]
2015-04-16 16:14 ` [PATCH 06/16] ALSA: hda - Move send_cmd / get_response to hdac_bus_ops Takashi Iwai
2015-04-16 16:14 ` [PATCH 07/16] ALSA: hda - Pass bus io_ops directly from the top-level driver Takashi Iwai
2015-04-16 16:14 ` [PATCH 08/16] ALSA: hda - Migrate hdac_stream into legacy driver Takashi Iwai
2015-04-16 16:14 ` [PATCH 09/16] ALSA: hda - Migrate more hdac_stream codes Takashi Iwai
2015-04-16 16:14 ` [PATCH 10/16] ALSA: hda - Embed bus into controller object Takashi Iwai
2015-04-16 16:14 ` [PATCH 11/16] ALSA: hda - Minor refactoring Takashi Iwai
2015-04-16 16:14 ` [PATCH 12/16] ALSA: hda - Move PCM format and rate handling code to core library Takashi Iwai
2015-04-16 16:14 ` [PATCH 13/16] ALSA: hda - Add missing inclusion of <linux/clocksource.h> Takashi Iwai
2015-04-16 16:14 ` [PATCH 14/16] ALSA: hda - Reenable tracepoints for controller Takashi Iwai
2015-04-16 16:14 ` [PATCH 15/16] ALSA: hda/tegra - Fix build error and warning Takashi Iwai
2015-04-16 16:14 ` [PATCH 16/16] ALSA: hda - Drop azx_sd_read*/write*() macros Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429200870-5288-6-git-send-email-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jeeja.kp@intel.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.