All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Elste <thomas.elste@imms.de>
To: linux-pm@vger.kernel.org
Cc: thomas.elste@imms.de
Subject: bq24190_charger: no status updates
Date: Thu, 28 May 2015 11:05:31 +0200	[thread overview]
Message-ID: <1432803932-5315-1-git-send-email-thomas.elste@imms.de> (raw)

Hi,

while searching for the cause of charger events not being detected on a
custom board with a BQ24190 charger, I think a found a minor problem in
its driver:

The bq24190_charger driver uses a flag for preventing the first change
in charger status, which is generated by an initial register clear, to
reach power supply subsystem via power_supply_changed. This flag is set
in the probe function and is supposed to be reset after a first status
change. This never happens as the condition for reset depends already
on the flag not being set.

I made a short patch which changes the flags reset condition.

Best regards
Thomas


             reply	other threads:[~2015-05-28  9:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28  9:05 Thomas Elste [this message]
2015-05-28  9:05 ` [PATCH] power: bq24190_charger: Change first_time flag reset condition Thomas Elste
2015-05-29  2:34   ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432803932-5315-1-git-send-email-thomas.elste@imms.de \
    --to=thomas.elste@imms.de \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.