All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: linux-samsung-soc@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, inki.dae@samsung.com,
	jy0922.shim@samsung.com, tjakobi@math.uni-bielefeld.de,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: [PATCH v9 08/18] drm/exynos: atomic phase 3: use atomic .set_config helper
Date: Thu, 28 May 2015 18:42:46 -0300	[thread overview]
Message-ID: <1432849376-12828-9-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1432849376-12828-1-git-send-email-gustavo@padovan.org>

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Now that phase 1 and 2 are complete switch .set_config helper to
use the atomic one.

v2: also remove .prepare() callback

v3: remove .mode_set() and .mode_set_base() and encoder's
.prepare() callbacks

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Joonyoung Shim <jy0922.shim@samsung.com>
Tested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
 drivers/gpu/drm/exynos/exynos_drm_crtc.c    | 10 +---------
 drivers/gpu/drm/exynos/exynos_drm_encoder.c |  6 ------
 2 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
index f782d1f..dd1ee7f 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
@@ -50,11 +50,6 @@ static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode)
 		drm_crtc_vblank_on(crtc);
 }
 
-static void exynos_drm_crtc_prepare(struct drm_crtc *crtc)
-{
-	/* drm framework doesn't check NULL. */
-}
-
 static void exynos_drm_crtc_commit(struct drm_crtc *crtc)
 {
 	struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
@@ -108,12 +103,9 @@ static void exynos_drm_crtc_disable(struct drm_crtc *crtc)
 
 static struct drm_crtc_helper_funcs exynos_crtc_helper_funcs = {
 	.dpms		= exynos_drm_crtc_dpms,
-	.prepare	= exynos_drm_crtc_prepare,
 	.commit		= exynos_drm_crtc_commit,
 	.mode_fixup	= exynos_drm_crtc_mode_fixup,
-	.mode_set	= drm_helper_crtc_mode_set,
 	.mode_set_nofb	= exynos_drm_crtc_mode_set_nofb,
-	.mode_set_base	= drm_helper_crtc_mode_set_base,
 	.disable	= exynos_drm_crtc_disable,
 };
 
@@ -190,7 +182,7 @@ static void exynos_drm_crtc_destroy(struct drm_crtc *crtc)
 }
 
 static struct drm_crtc_funcs exynos_crtc_funcs = {
-	.set_config	= drm_crtc_helper_set_config,
+	.set_config	= drm_atomic_helper_set_config,
 	.page_flip	= exynos_drm_crtc_page_flip,
 	.destroy	= exynos_drm_crtc_destroy,
 	.reset = drm_atomic_helper_crtc_reset,
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
index 57de0bd..915de13 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
@@ -76,11 +76,6 @@ static void exynos_drm_encoder_mode_set(struct drm_encoder *encoder,
 		display->ops->mode_set(display, adjusted_mode);
 }
 
-static void exynos_drm_encoder_prepare(struct drm_encoder *encoder)
-{
-	/* drm framework doesn't check NULL. */
-}
-
 static void exynos_drm_encoder_commit(struct drm_encoder *encoder)
 {
 	struct exynos_drm_encoder *exynos_encoder = to_exynos_encoder(encoder);
@@ -111,7 +106,6 @@ static struct drm_encoder_helper_funcs exynos_encoder_helper_funcs = {
 	.dpms		= exynos_drm_encoder_dpms,
 	.mode_fixup	= exynos_drm_encoder_mode_fixup,
 	.mode_set	= exynos_drm_encoder_mode_set,
-	.prepare	= exynos_drm_encoder_prepare,
 	.commit		= exynos_drm_encoder_commit,
 	.disable	= exynos_drm_encoder_disable,
 };
-- 
2.1.0

  parent reply	other threads:[~2015-05-28 21:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28 21:42 [PATCH v9 00/18] drm/exynos: atomic modesetting support Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 01/18] drm/exynos: fix source data argument for plane Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 02/18] drm/exynos: atomic phase 1: use drm_plane_helper_update() Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 03/18] drm/exynos: atomic phase 1: use drm_plane_helper_disable() Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 04/18] drm/exynos: atomic phase 1: add .mode_set_nofb() callback Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 05/18] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy() Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 06/18] drm/exynos: atomic phase 2: keep track of framebuffer pointer Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 07/18] drm/exynos: atomic phase 3: atomic updates of planes Gustavo Padovan
2015-05-28 21:42 ` Gustavo Padovan [this message]
2015-05-28 21:42 ` [PATCH v9 09/18] drm/exynos: atomic phase 3: convert page flips Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 10/18] drm/exynos: remove exported functions from exynos_drm_plane Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 11/18] drm/exynos: don't disable unused functions at init Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 12/18] drm/exynos: move exynos_drm_crtc_disable() Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 13/18] drm/exynos: add exynos specific .atomic_commit() Gustavo Padovan
2015-05-29  6:21   ` Joonyoung Shim
2015-05-28 21:42 ` [PATCH v9 14/18] drm/exynos: atomic dpms support Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 15/18] drm/exynos: remove unnecessary calls to disable_plane() Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 16/18] drm/exynos: split exynos_crtc->dpms in enable() and disable() Gustavo Padovan
2015-05-29  6:23   ` Joonyoung Shim
2015-05-28 21:42 ` [PATCH v9 17/18] drm/exynos: rename win_commit/disable to atomic-like names Gustavo Padovan
2015-05-28 21:42 ` [PATCH v9 18/18] drm/exynos: don't disable planes already disabled Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432849376-12828-9-git-send-email-gustavo@padovan.org \
    --to=gustavo@padovan.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.