All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Darren Hart <dvhart@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Ike Panhc" <ike.pan@canonical.com>,
	linux-acpi@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net,
	acpi4asus-user@lists.sourceforge.net,
	"Henrique de Moraes Holschuh" <ibm-acpi@hmh.eng.br>,
	dri-devel@lists.freedesktop.org,
	"Azael Avalos" <coproscefalo@gmail.com>,
	"Lee Chun-Yi" <jlee@suse.com>,
	"Mattia Dongili" <malattia@linux.it>,
	"Cezary Jackiewicz" <cezary.jackiewicz@gmail.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	"Aaron Lu" <aaron.lu@intel.com>
Subject: [PATCH v2 30/32] toshiba-acpi: Port to new backlight interface selection API
Date: Fri, 12 Jun 2015 13:23:49 +0200	[thread overview]
Message-ID: <1434108231-12323-31-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1434108231-12323-1-git-send-email-hdegoede@redhat.com>

Port the backlight selection logic to the new backlight interface
selection API.

Also fix a compiler warning about bt_present not being initialized.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/toshiba_acpi.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index 9956b990..c484d47 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -2640,14 +2640,11 @@ static int toshiba_acpi_setup_backlight(struct toshiba_acpi_dev *dev)
 	 */
 	if (dev->tr_backlight_supported ||
 	    dmi_check_system(toshiba_vendor_backlight_dmi))
-		acpi_video_dmi_promote_vendor();
+		acpi_video_set_dmi_backlight_type(acpi_backlight_vendor);
 
-	if (acpi_video_backlight_support())
+	if (acpi_video_get_backlight_type() != acpi_backlight_vendor)
 		return 0;
 
-	/* acpi-video may have loaded before we called dmi_promote_vendor() */
-	acpi_video_unregister_backlight();
-
 	memset(&props, 0, sizeof(props));
 	props.type = BACKLIGHT_PLATFORM;
 	props.max_brightness = HCI_LCD_BRIGHTNESS_LEVELS - 1;
@@ -2733,7 +2730,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev)
 	const char *hci_method;
 	u32 special_functions;
 	u32 dummy;
-	bool bt_present;
+	bool bt_present = false;
 	int ret = 0;
 
 	if (toshiba_acpi)
-- 
2.4.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-06-12 11:23 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12 11:23 [PATCH v2 00/32] acpi-video: Rewrite backlight interface selection logic Hans de Goede
2015-06-12 11:23 ` [PATCH v2 01/32] apple-gmux: Stop using acpi_video_dmi_demote_vendor() Hans de Goede
2015-06-12 11:23 ` [PATCH v2 02/32] acpi-video-detect: Remove the unused acpi_video_dmi_demote_vendor() function Hans de Goede
2015-06-12 11:23 ` [PATCH v2 03/32] acpi-video-detect: Make acpi_video_get_capabilities a private function Hans de Goede
2015-06-12 11:23 ` [PATCH v2 04/32] acpi-video-detect: Move acpi_is_video_device() to acpi/scan.c Hans de Goede
2015-06-12 11:23 ` [PATCH v2 05/32] acpi-video-detect: Move acpi_osi_is_win8 to osl.c Hans de Goede
2015-06-12 11:23 ` [PATCH v2 06/32] acpi-video-detect: video: Make video_detect code part of the video module Hans de Goede
2015-06-12 11:23 ` [PATCH v2 07/32] acpi-video-detect: Rewrite backlight interface selection logic Hans de Goede
2015-06-12 11:23 ` [PATCH v2 08/32] acpi-video-detect: Unregister acpi_video backlight when dmi quirks are added Hans de Goede
2015-06-12 11:23 ` [PATCH v2 09/32] drm: i915: Port to new backlight interface selection API Hans de Goede
2015-06-12 11:23 ` [PATCH v2 10/32] acpi-video: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 11/32] acpi-video: Move backlight notifier to video_detect.c Hans de Goede
2015-06-12 11:23 ` [PATCH v2 12/32] acpi-video: Move dmi_check_system from module_init to acpi_video_register Hans de Goede
2015-06-12 11:23 ` [PATCH v2 13/32] acpi-video: Fix acpi_video _register vs _unregister_backlight race Hans de Goede
2015-06-12 11:23 ` [PATCH v2 14/32] acer-wmi: Port to new backlight interface selection API Hans de Goede
2015-06-12 11:23 ` [PATCH v2 15/32] apple-gmux: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 16/32] asus-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 17/32] asus-wmi: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 18/32] compal-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 19/32] dell-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 20/32] dell-wmi: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 21/32] eeepc-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 22/32] fujitsu-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 23/32] ideapad-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 24/32] intel-oaktrail: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 25/32] msi-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 26/32] msi-wmi: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 27/32] samsung-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 28/32] sony-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 29/32] thinkpad-acpi: " Hans de Goede
2015-06-12 11:23 ` Hans de Goede [this message]
2015-06-14  3:15   ` [PATCH v2 30/32] toshiba-acpi: " Azael Avalos
2015-06-16 12:53     ` Hans de Goede
2015-06-12 11:23 ` [PATCH v2 31/32] acpi-video-detect: Remove old API Hans de Goede
2015-06-12 11:23 ` [PATCH v2 32/32] acpi-video: Make acpi_video_unregister_backlight() private Hans de Goede
2015-06-15 23:22 ` [PATCH v2 00/32] acpi-video: Rewrite backlight interface selection logic Rafael J. Wysocki
2015-06-17  3:39   ` Darren Hart
2015-06-17  9:36     ` Rafael J. Wysocki
2015-06-18 21:05       ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434108231-12323-31-git-send-email-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=aaron.lu@intel.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=bskeggs@redhat.com \
    --cc=cezary.jackiewicz@gmail.com \
    --cc=coproscefalo@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dvhart@infradead.org \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=ike.pan@canonical.com \
    --cc=jlee@suse.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=malattia@linux.it \
    --cc=mjg59@srcf.ucam.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.