All of lore.kernel.org
 help / color / mirror / Atom feed
From: Archit Taneja <architt@codeaurora.org>
To: dri-devel@lists.freedesktop.org, daniel@ffwll.ch
Cc: linux-arm-msm@vger.kernel.org
Subject: [PATCH 04/25] drm/fb_helper: Create wrappers for blit, copyarea and fillrect funcs
Date: Mon, 13 Jul 2015 12:08:00 +0530	[thread overview]
Message-ID: <1436769501-4105-5-git-send-email-architt@codeaurora.org> (raw)
In-Reply-To: <1436769501-4105-1-git-send-email-architt@codeaurora.org>

drm drivers that emulate fbdev populate their fb_fillrect, fb_copyarea
and fb_imageblit fb_ops with the help of cfb_* or sys_* fbdev core
helper functions.

Create drm_fb_helper functions that wrap around these calls.

This is part of an effort to prevent drm drivers from calling fbdev
functions directly, in order to make fbdev emulation a top level drm
option.

Signed-off-by: Archit Taneja <architt@codeaurora.org>
---
 drivers/gpu/drm/Kconfig         |  6 ++++++
 drivers/gpu/drm/drm_fb_helper.c | 48 +++++++++++++++++++++++++++++++++++++++++
 include/drm/drm_fb_helper.h     | 14 ++++++++++++
 3 files changed, 68 insertions(+)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index b284cdc..e373f8a 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -38,6 +38,12 @@ config DRM_KMS_FB_HELPER
 	select FRAMEBUFFER_CONSOLE if !EXPERT
 	select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE
 	select FB_SYS_FOPS
+	select FB_SYS_FILLRECT
+	select FB_SYS_COPYAREA
+	select FB_SYS_IMAGEBLIT
+	select FB_CFB_FILLRECT
+	select FB_CFB_COPYAREA
+	select FB_CFB_IMAGEBLIT
 	help
 	  FBDEV helpers for KMS drivers.
 
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 795547e..55b5212 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -764,6 +764,54 @@ ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_write);
 
+void drm_fb_helper_sys_fillrect(struct fb_info *info,
+		const struct fb_fillrect *rect)
+{
+	if (info)
+		sys_fillrect(info, rect);
+}
+EXPORT_SYMBOL(drm_fb_helper_sys_fillrect);
+
+void drm_fb_helper_sys_copyarea(struct fb_info *info,
+		const struct fb_copyarea *area)
+{
+	if (info)
+		sys_copyarea(info, area);
+}
+EXPORT_SYMBOL(drm_fb_helper_sys_copyarea);
+
+void drm_fb_helper_sys_imageblit(struct fb_info *info,
+		const struct fb_image *image)
+{
+	if (info)
+		sys_imageblit(info, image);
+}
+EXPORT_SYMBOL(drm_fb_helper_sys_imageblit);
+
+void drm_fb_helper_cfb_fillrect(struct fb_info *info,
+		const struct fb_fillrect *rect)
+{
+	if (info)
+		cfb_fillrect(info, rect);
+}
+EXPORT_SYMBOL(drm_fb_helper_cfb_fillrect);
+
+void drm_fb_helper_cfb_copyarea(struct fb_info *info,
+		const struct fb_copyarea *area)
+{
+	if (info)
+		cfb_copyarea(info, area);
+}
+EXPORT_SYMBOL(drm_fb_helper_cfb_copyarea);
+
+void drm_fb_helper_cfb_imageblit(struct fb_info *info,
+		const struct fb_image *image)
+{
+	if (info)
+		cfb_imageblit(info, image);
+}
+EXPORT_SYMBOL(drm_fb_helper_cfb_imageblit);
+
 static int setcolreg(struct drm_crtc *crtc, u16 red, u16 green,
 		     u16 blue, u16 regno, struct fb_info *info)
 {
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index f74e59e..aa45837 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -152,6 +152,20 @@ ssize_t drm_fb_helper_sys_read(struct fb_info *info, char __user *buf,
 ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 			size_t count, loff_t *ppos);
 
+void drm_fb_helper_sys_fillrect(struct fb_info *info,
+		const struct fb_fillrect *rect);
+void drm_fb_helper_sys_copyarea(struct fb_info *info,
+		const struct fb_copyarea *area);
+void drm_fb_helper_sys_imageblit(struct fb_info *info,
+		const struct fb_image *image);
+
+void drm_fb_helper_cfb_fillrect(struct fb_info *info,
+		const struct fb_fillrect *rect);
+void drm_fb_helper_cfb_copyarea(struct fb_info *info,
+		const struct fb_copyarea *area);
+void drm_fb_helper_cfb_imageblit(struct fb_info *info,
+		const struct fb_image *image);
+
 int drm_fb_helper_setcmap(struct fb_cmap *cmap, struct fb_info *info);
 
 int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-07-13  6:38 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  6:37 [PATCH 00/25] drm: fb emulation: Step 1: Create new drm_fb_helper wrapper funcs Archit Taneja
2015-07-13  6:37 ` [PATCH 01/25] drm/fb_helper: Add drm_fb_helper functions to manage fb_info creation Archit Taneja
2015-07-13  6:37 ` [PATCH 02/25] drm/fb_helper: Create a wrapper for unlink_framebuffer Archit Taneja
2015-07-13  7:30   ` Daniel Vetter
2015-07-13  6:37 ` [PATCH 03/25] drm/fb_helper: Create wrappers for fb_sys_read/write funcs Archit Taneja
2015-07-13  7:31   ` Daniel Vetter
2015-07-13  9:59     ` Archit Taneja
2015-07-13  7:39   ` Daniel Vetter
2015-07-13  6:38 ` Archit Taneja [this message]
2015-07-13  7:40   ` [PATCH 04/25] drm/fb_helper: Create wrappers for blit, copyarea and fillrect funcs Daniel Vetter
2015-07-13  6:38 ` [PATCH 05/25] drm/fb_helper: Create a wrapper for fb_set_suspend Archit Taneja
2015-07-13  6:38 ` [PATCH 06/25] drm/fb_helper: Create a wrapper for remove_conflicting_framebuffers Archit Taneja
2015-07-13  6:38 ` [PATCH 07/25] drm/cirrus: Use new drm_fb_helper functions Archit Taneja
2015-07-13  6:38 ` [PATCH 08/25] drm/rockchip: " Archit Taneja
2015-07-13  6:38 ` [PATCH 09/25] drm/armada: " Archit Taneja
2015-07-13  6:38 ` [PATCH 10/25] drm/ast: " Archit Taneja
2015-07-13  6:38 ` [PATCH 11/25] drm/omap: " Archit Taneja
2015-07-13  6:38 ` [PATCH 12/25] drm/tegra: " Archit Taneja
2015-07-14  8:50   ` Thierry Reding
2015-07-14  9:11     ` Archit Taneja
2015-07-13  6:38 ` [PATCH 13/25] drm/msm: " Archit Taneja
2015-07-13  6:38 ` [PATCH 14/25] drm/exynos: " Archit Taneja
2015-08-11  9:04   ` Inki Dae
2015-08-11  9:11     ` Inki Dae
2015-07-13  6:38 ` [PATCH 15/25] drm/gma500: " Archit Taneja
2015-07-13  6:38 ` [PATCH 16/25] drm/mgag200: " Archit Taneja
2015-07-13  6:38 ` [PATCH 17/25] drm/radeon: " Archit Taneja
2015-07-13  6:38 ` [PATCH 18/25] drm/qxl: " Archit Taneja
2015-07-13  6:38 ` [PATCH 19/25] drm/i915: " Archit Taneja
2015-07-13  6:38 ` [PATCH 20/25] drm/nouveau: " Archit Taneja
2015-07-13  6:38 ` [PATCH 21/25] drm/udl: " Archit Taneja
2015-07-13  6:38 ` [PATCH 22/25] drm/boschs: " Archit Taneja
2015-07-13  6:38 ` [PATCH 23/25] drm/amdgpu: " Archit Taneja
2015-07-13  6:38 ` [PATCH 24/25] drm/virtio: " Archit Taneja
2015-07-13  6:38 ` [PATCH 25/25] drm/fb_cma_helper: " Archit Taneja
2015-07-13  8:07 ` [PATCH 00/25] drm: fb emulation: Step 1: Create new drm_fb_helper wrapper funcs Daniel Vetter
2015-07-13 10:29   ` Archit Taneja
2015-07-13 14:11     ` Daniel Vetter
2015-07-13 15:25 ` Alex Deucher
2015-07-22  6:59 ` [PATCH v2 " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 01/25] drm/fb_helper: Add drm_fb_helper functions to manage fb_info creation Archit Taneja
2015-07-22  6:59   ` [PATCH v2 02/25] drm/fb_helper: Create a wrapper for unlink_framebuffer Archit Taneja
2015-07-22  6:59   ` [PATCH v2 03/25] drm/fb_helper: Create wrappers for fb_sys_read/write funcs Archit Taneja
2015-07-22  6:59   ` [PATCH v2 04/25] drm/fb_helper: Create wrappers for blit, copyarea and fillrect funcs Archit Taneja
2015-07-22  6:59   ` [PATCH v2 05/25] drm/fb_helper: Create a wrapper for fb_set_suspend Archit Taneja
2015-07-22  6:59   ` [PATCH v2 06/25] drm/fb_helper: Create a wrapper for remove_conflicting_framebuffers Archit Taneja
2015-07-22  6:59   ` [PATCH v2 07/25] drm/cirrus: Use new drm_fb_helper functions Archit Taneja
2015-07-22  6:59   ` [PATCH v2 08/25] drm/rockchip: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 09/25] drm/armada: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 10/25] drm/ast: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 11/25] drm/omap: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 12/25] drm/tegra: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 13/25] drm/msm: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 14/25] drm/exynos: " Archit Taneja
2015-08-11 12:27     ` Inki Dae
2015-07-22  6:59   ` [PATCH v2 15/25] drm/gma500: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 16/25] drm/mgag200: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 17/25] drm/radeon: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 18/25] drm/qxl: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 19/25] drm/i915: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 20/25] drm/nouveau: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 21/25] drm/udl: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 22/25] drm/bochs: " Archit Taneja
2015-07-22  6:59   ` [PATCH v2 23/25] drm/amdgpu: " Archit Taneja
2015-07-22  7:00   ` [PATCH v2 24/25] drm/virtio: " Archit Taneja
2015-07-22  7:00   ` [PATCH v2 25/25] drm/fb_cma_helper: " Archit Taneja
2015-07-22  7:41   ` [PATCH v2 00/25] drm: fb emulation: Step 1: Create new drm_fb_helper wrapper funcs Daniel Vetter
2015-07-22  8:34     ` Archit Taneja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436769501-4105-5-git-send-email-architt@codeaurora.org \
    --to=architt@codeaurora.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.