From: Shuai Ruan <shuai.ruan@linux.intel.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/xstate: don't clobber or leak state when using XSAVES
Date: Thu, 5 May 2016 09:20:50 +0800 [thread overview]
Message-ID: <14373.2278644622$1462411205@news.gmane.org> (raw)
In-Reply-To: <20160429091342.GA12693@citrix.com>
On Fri, Apr 29, 2016 at 10:13:42AM +0100, Wei Liu wrote:
> On Fri, Apr 29, 2016 at 09:21:39AM +0800, Shuai Ruan wrote:
> > On Mon, Apr 25, 2016 at 01:07:54AM -0600, Jan Beulich wrote:
> > > Commit 4d27280572 ("x86/xsaves: fix overwriting between non-lazy/lazy
> > > xsaves") switched to always saving full state when using compacted
> > > format (which is the only one XSAVES allows). It didn't, however, also
> > > adjust the restore side: In order to save full state, we also need to
> > > make sure we always load full state, or else the subject vCPU's state
> > > would get clobbered by that of the vCPU which happened to last have in
> > > use the respective component(s).
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > This looks good to me.
> >
>
> Can we take this as an ack or a review tag?
>
> Wei.
Yes.
Reviewed-by: Shuai Ruan <shuai.ruan@linux.intel.com>
Thanks
>
> > Thanks
> >
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-05-05 1:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 7:07 [PATCH] x86/xstate: don't clobber or leak state when using XSAVES Jan Beulich
2016-04-25 11:39 ` Wei Liu
2016-04-26 9:25 ` Andrew Cooper
2016-04-29 1:21 ` Shuai Ruan
[not found] ` <20160429012139.GA4359@shuai.ruan@linux.intel.com>
2016-04-29 9:13 ` Wei Liu
2016-05-05 1:20 ` Shuai Ruan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='14373.2278644622$1462411205@news.gmane.org' \
--to=shuai.ruan@linux.intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.