All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kahola <mika.kahola@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v3 02/11] drm/i915: DisplayPort pixel clock check
Date: Fri, 31 Jul 2015 15:13:51 +0300	[thread overview]
Message-ID: <1438344840-3490-3-git-send-email-mika.kahola@intel.com> (raw)
In-Reply-To: <1438344840-3490-1-git-send-email-mika.kahola@intel.com>

It is possible the we request to have a mode that has
higher pixel clock than our HW can support. This patch
checks if requested pixel clock is lower than the one
supported by the HW. The requested mode is discarded
if we cannot support the requested pixel clock.

This patch applies to DisplayPort.

V2:
- removed computation for max DOT clock

V3:
- cleanup by removing unnecessary lines

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 44f8a32..5faeadb 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -206,6 +206,7 @@ intel_dp_mode_valid(struct drm_connector *connector,
 	struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;
 	int target_clock = mode->clock;
 	int max_rate, mode_rate, max_lanes, max_link_clock;
+	int max_pixclk = to_i915(connector->dev)->max_dotclk;
 
 	if (is_edp(intel_dp) && fixed_mode) {
 		if (mode->hdisplay > fixed_mode->hdisplay)
@@ -223,7 +224,7 @@ intel_dp_mode_valid(struct drm_connector *connector,
 	max_rate = intel_dp_max_data_rate(max_link_clock, max_lanes);
 	mode_rate = intel_dp_link_required(target_clock, 18);
 
-	if (mode_rate > max_rate)
+	if (mode_rate > max_rate || target_clock > max_pixclk)
 		return MODE_CLOCK_HIGH;
 
 	if (mode->clock < 10000)
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-07-31 12:11 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 12:13 [PATCH v3 00/11] Check pixel clock when setting mode Mika Kahola
2015-07-31 12:13 ` [PATCH v3 01/11] drm/i915: Store max dotclock Mika Kahola
2015-08-12 17:30   ` Ville Syrjälä
2015-08-12 19:01     ` Ville Syrjälä
2015-08-13  8:21       ` Mika Kahola
2015-07-31 12:13 ` Mika Kahola [this message]
2015-08-12 18:50   ` [PATCH v3 02/11] drm/i915: DisplayPort pixel clock check Ville Syrjälä
2015-07-31 12:13 ` [PATCH v3 03/11] drm/i915: HDMI " Mika Kahola
2015-08-12 18:34   ` Ville Syrjälä
2015-08-14  8:30     ` Daniel Vetter
2015-08-14 13:03       ` Ville Syrjälä
2015-08-14 13:11         ` Daniel Vetter
2015-07-31 12:13 ` [PATCH v3 04/11] drm/i915: LVDS " Mika Kahola
2015-08-12 17:40   ` Ville Syrjälä
2015-07-31 12:13 ` [PATCH v3 05/11] drm/i915: SDVO " Mika Kahola
2015-08-12 17:46   ` Ville Syrjälä
2015-07-31 12:13 ` [PATCH v3 06/11] drm/i915: DSI " Mika Kahola
2015-08-12 18:15   ` Ville Syrjälä
2015-07-31 12:13 ` [PATCH v3 07/11] drm/i915: CRT " Mika Kahola
2015-08-12 18:59   ` Ville Syrjälä
2015-07-31 12:13 ` [PATCH v3 08/11] drm/i915: TV " Mika Kahola
2015-08-12 18:24   ` Ville Syrjälä
2015-08-14  8:33     ` Daniel Vetter
2015-07-31 12:13 ` [PATCH v3 09/11] drm/i915: DisplayPort-MST " Mika Kahola
2015-08-12 18:49   ` Ville Syrjälä
2015-08-14  8:36     ` Daniel Vetter
2015-07-31 12:13 ` [PATCH v3 10/11] drm/i915: DVO " Mika Kahola
2015-08-12 18:41   ` Ville Syrjälä
2015-07-31 12:14 ` [PATCH v3 11/11] drm/i915: Max DOT clock frequency to debugfs Mika Kahola
2015-08-10 13:25   ` shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438344840-3490-3-git-send-email-mika.kahola@intel.com \
    --to=mika.kahola@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.