All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
To: ville.syrjala@linux.intel.com, jani.nikula@linux.intel.com,
	intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/4] drm/i915: fix link rates reported for SKL
Date: Mon, 17 Aug 2015 17:45:11 +0530	[thread overview]
Message-ID: <1439813711-2438-5-git-send-email-sivakumar.thulasimani@intel.com> (raw)
In-Reply-To: <1439813711-2438-1-git-send-email-sivakumar.thulasimani@intel.com>

From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>

This patch fixes the bug that SKL SKUs before B0 might return
HBR2 as supported even though it is not supposed to be enabled
on such platforms.

Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 03523b3..963fdae 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1224,21 +1224,23 @@ static bool intel_dp_is_hbr2_supported(struct drm_device *dev)
 static int
 intel_dp_source_rates(struct drm_device *dev, const int **source_rates)
 {
+	int size = 0;
 	if (IS_BROXTON(dev)) {
 		*source_rates = bxt_rates;
-		return ARRAY_SIZE(bxt_rates);
+		size = ARRAY_SIZE(bxt_rates);
 	} else if (IS_SKYLAKE(dev)) {
 		*source_rates = skl_rates;
-		return ARRAY_SIZE(skl_rates);
+		size = ARRAY_SIZE(skl_rates);
+	} else {
+		*source_rates = default_rates;
+		size = ARRAY_SIZE(default_rates);
 	}
 
-	*source_rates = default_rates;
-
 	/* This depends on the fact that 5.4 is last value in the array */
 	if (intel_dp_is_hbr2_supported(dev))
-		return (DP_LINK_BW_5_4 >> 3) + 1;
+		return size;
 	else
-		return (DP_LINK_BW_2_7 >> 3) + 1;
+		return size - 1;
 }
 
 static void
-- 
1.7.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-08-17 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 12:15 [PATCH 0/4] HBR2 cleanup for CHV/SKL Sivakumar Thulasimani
2015-08-17 12:15 ` [PATCH 1/4] Revert "drm/i915: Add eDP intermediate frequencies for CHV" Sivakumar Thulasimani
2015-08-17 12:15 ` [PATCH 2/4] drm/i915: remove HBR2 from chv supported list Sivakumar Thulasimani
2015-08-17 12:15 ` [PATCH 3/4] drm/i915: Avoid TP3 on CHV Sivakumar Thulasimani
2015-08-17 12:25   ` Jani Nikula
2015-08-17 12:15 ` Sivakumar Thulasimani [this message]
2015-08-17 12:29   ` [PATCH 4/4] drm/i915: fix link rates reported for SKL Jani Nikula
2015-08-18  5:39     ` Sivakumar Thulasimani
2015-08-17 12:41   ` Ville Syrjälä
2015-08-18  5:35     ` Sivakumar Thulasimani
2015-08-19 12:02   ` shuang.he
2015-08-18  5:37 [PATCH 0/4] HBR2 cleanup for CHV/SKL V2 Sivakumar Thulasimani
2015-08-18  5:37 ` [PATCH 4/4] drm/i915: fix link rates reported for SKL Sivakumar Thulasimani
2015-08-24  7:40   ` Jani Nikula
2015-08-27  8:16   ` shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439813711-2438-5-git-send-email-sivakumar.thulasimani@intel.com \
    --to=sivakumar.thulasimani@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.