All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH 07/16] drm/exynos/hdmi: fix removal order
Date: Fri, 25 Sep 2015 14:48:20 +0200	[thread overview]
Message-ID: <1443185309-13827-8-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <1443185309-13827-1-git-send-email-a.hajda@samsung.com>

DRM device should be destroyed before releasing resources.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_hdmi.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 50ced709..725ddb5 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -2046,15 +2046,17 @@ static int hdmi_remove(struct platform_device *pdev)
 
 	cancel_delayed_work_sync(&hdata->hotplug_work);
 
+	component_del(&pdev->dev, &hdmi_component_ops);
+
+	pm_runtime_disable(&pdev->dev);
+
 	if (hdata->res.reg_hdmi_en)
 		regulator_disable(hdata->res.reg_hdmi_en);
 
 	if (hdata->hdmiphy_port)
 		put_device(&hdata->hdmiphy_port->dev);
-	put_device(&hdata->ddc_adpt->dev);
 
-	pm_runtime_disable(&pdev->dev);
-	component_del(&pdev->dev, &hdmi_component_ops);
+	put_device(&hdata->ddc_adpt->dev);
 
 	return 0;
 }
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-09-25 12:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 12:48 [PATCH 00/16] drm/exynos/hdmi: refactoring/cleanup patches Andrzej Hajda
2015-09-25 12:48 ` [PATCH 01/16] drm/exynos/hdmi: remove support for deprecated compatible Andrzej Hajda
2015-09-30 14:35   ` Gustavo Padovan
2015-09-25 12:48 ` [PATCH 02/16] dt-bindings: remove deprecated compatible string from exynos-hdmi Andrzej Hajda
2015-09-30 14:36   ` Gustavo Padovan
2015-11-17  3:40     ` Krzysztof Kozlowski
2015-11-18  8:33       ` [PATCH 02/16 REBASED] " Andrzej Hajda
2015-11-18  9:14         ` Krzysztof Kozlowski
2015-09-25 12:48 ` [PATCH 03/16] drm/exynos/hdmi: use mappings for registers with IP dependent address Andrzej Hajda
2015-09-30 14:47   ` Gustavo Padovan
2015-09-25 12:48 ` [PATCH 04/16] drm/exynos/hdmi: move PLL stabilization check code to separate function Andrzej Hajda
2015-09-30 14:48   ` Gustavo Padovan
2015-09-25 12:48 ` [PATCH 05/16] drm/exynos/hdmi: simplify HDMI-PHY power sequence Andrzej Hajda
2015-09-30 14:53   ` Gustavo Padovan
2015-09-25 12:48 ` [PATCH 06/16] drm/exynos/hdmi: replace all writeb with writel Andrzej Hajda
2015-09-30 14:53   ` Gustavo Padovan
2015-09-25 12:48 ` Andrzej Hajda [this message]
2015-09-30 14:57   ` [PATCH 07/16] drm/exynos/hdmi: fix removal order Gustavo Padovan
2015-09-25 12:48 ` [PATCH 08/16] drm/exynos/hdmi: use optional regulator_get for hdmi-en Andrzej Hajda
2015-09-25 12:48 ` [PATCH 09/16] drm/exynos/hdmi: use constant size array for regulators Andrzej Hajda
2015-09-30 15:08   ` Gustavo Padovan
2015-09-25 12:48 ` [PATCH 10/16] drm/exynos/hdmi: simplify clock re-parenting Andrzej Hajda
2015-09-25 12:48 ` [PATCH 11/16] drm/exynos/hdmi: convert to gpiod API Andrzej Hajda
2015-09-25 12:48 ` [PATCH 12/16] drm/exynos/hdmi: remove deprecated hdmi_resources structure Andrzej Hajda
2015-09-25 12:48 ` [PATCH 13/16] drm/exynos/hdmi: convert container_of macro to inline function Andrzej Hajda
2015-09-30 15:08   ` Gustavo Padovan
2015-09-25 12:48 ` [PATCH 14/16] drm/exynos/hdmi: improve HDMI/ACR related code Andrzej Hajda
2015-09-25 12:48 ` [PATCH 15/16] drm/exynos/hdmi: remove unused field Andrzej Hajda
2015-09-30 15:09   ` Gustavo Padovan
2015-09-25 12:48 ` [PATCH 16/16] drm: exynos: mixer: fix using usleep() in atomic context Andrzej Hajda
2015-10-12 13:26 ` [PATCH 00/16] drm/exynos/hdmi: refactoring/cleanup patches Inki Dae
2015-10-20  9:19   ` Andrzej Hajda
2015-10-20 12:07     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443185309-13827-8-git-send-email-a.hajda@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.