From: Waiman Long <longman@redhat.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm, memcg: do full scan initially in force_empty
Date: Mon, 3 Aug 2020 11:26:56 -0400 (EDT) [thread overview]
Message-ID: <1448744273.26026905.1596468416644.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CALOAHbAACOODfWRUKS24K-j2Z0Lr1S-HwqjuBWoBH8FFudEgcw@mail.gmail.com>
Yafang,
>>
>> > The force_empty will also drop the pagecache pages, which is not
>> > expected by us.
>>
>> force_empty is intended to reclaim _all_ pages.
>>
>> > The global drop_caches can't work either because it will drop slabs in
>> > other memcgs.
>> > That is why I want to introduce per memcg drop_caches.
>>
>> Problems with negative dentries has been already discussed in the past.
>> I believe there was no conclusion so far. Please try to dig into
>> archives.
>
>I have read the proposal of Waiman. But it seems there isn't a conclusion yet.
>If the kernel can't fix this issue perfectly, then giving the user a
>chance to work around it would be a possible solution - drop_caches is
>that kind of workaround.
I am sorry for failing to follow up on the negative dentry patches. Is
your reason of doing this patch primarily because of the negative dentry
build-up? Uncontrollable negative dentry buildup is a problem that should be
addressed. I will work on an updated patch and post it ASAP.
Cheers,
Longman
prev parent reply other threads:[~2020-08-03 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 7:40 [PATCH] mm, memcg: do full scan initially in force_empty Yafang Shao
2020-07-30 11:26 ` Michal Hocko
2020-07-31 1:50 ` Yafang Shao
2020-08-03 10:12 ` Michal Hocko
2020-08-03 13:20 ` Yafang Shao
2020-08-03 13:56 ` Michal Hocko
2020-08-03 14:18 ` Yafang Shao
2020-08-03 14:26 ` Yafang Shao
2020-08-03 14:37 ` Michal Hocko
2020-08-03 14:34 ` Michal Hocko
2020-08-03 15:26 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448744273.26026905.1596468416644.JavaMail.zimbra@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.