All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: [PATCH 1/3] rcar: ctu: Avoid use of ret uninitialised
Date: Mon, 14 Dec 2015 12:07:29 +0000	[thread overview]
Message-ID: <1450094851-27525-1-git-send-email-broonie@kernel.org> (raw)

We use ret as the return value from the rsnd_ctu_probe() but if there
are no child nodes and no errors then we will never initialize ret leading
to build warnings. Ensure ret is initialized before we iterate over the
child nodes to avoid this.

Signed-off-by: Mark Brown <broonie@kernel.org>
---

Perhaps this should be an error instead?  It's not like it's a sensible
configuration...

 sound/soc/sh/rcar/ctu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sh/rcar/ctu.c b/sound/soc/sh/rcar/ctu.c
index 7c1e190cd389..d53a225d19e9 100644
--- a/sound/soc/sh/rcar/ctu.c
+++ b/sound/soc/sh/rcar/ctu.c
@@ -111,6 +111,7 @@ int rsnd_ctu_probe(struct rsnd_priv *priv)
 	priv->ctu	= ctu;
 
 	i = 0;
+	ret = 0;
 	for_each_child_of_node(node, np) {
 		ctu = rsnd_ctu_get(priv, i);
 
-- 
2.6.2

             reply	other threads:[~2015-12-14 12:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 12:07 Mark Brown [this message]
2015-12-14 12:07 ` [PATCH 2/3] rcar: dvc: Avoid use of ret uninitialised Mark Brown
2015-12-15 22:41   ` Applied "rcar: dvc: Avoid use of ret uninitialised" to the asoc tree Mark Brown
2015-12-14 12:07 ` [PATCH 3/3] rcar: mux: Avoid use of ret uninitialised Mark Brown
2015-12-15 22:41   ` Applied "rcar: mux: Avoid use of ret uninitialised" to the asoc tree Mark Brown
2015-12-14 23:32 ` [PATCH 1/3] rcar: ctu: Avoid use of ret uninitialised Kuninori Morimoto
2015-12-14 23:36 ` Kuninori Morimoto
2015-12-15 22:41 ` Applied "rcar: ctu: Avoid use of ret uninitialised" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450094851-27525-1-git-send-email-broonie@kernel.org \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.