From: "Radim Krčmář" <rkrcmar@redhat.com>
To: kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Andrew Jones <drjones@redhat.com>
Subject: [PATCH kvm-unit-tests 4/6] run_tests: generalize check
Date: Mon, 14 Dec 2015 22:24:19 +0100 [thread overview]
Message-ID: <1450128261-21170-5-git-send-email-rkrcmar@redhat.com> (raw)
In-Reply-To: <1450128261-21170-1-git-send-email-rkrcmar@redhat.com>
config attribute "check" is currently unused.
Provide a simple implementation instead of removing it.
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
run_tests.sh | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/run_tests.sh b/run_tests.sh
index 4d813b9a7084..b0b064f2e341 100755
--- a/run_tests.sh
+++ b/run_tests.sh
@@ -35,17 +35,10 @@ function run()
return
fi
- # check a file for a particular value before running a test
- # the check line can contain multiple files to check separated by a space
- # but each check parameter needs to be of the form <path>=<value>
- for check_param in ${check[@]}; do
- path=${check_param%%=*}
- value=${check_param#*=}
- if [ "$path" ] && [ "$(cat $path)" != "$value" ]; then
- echo "skip $1 ($path not equal to $value)"
- return
- fi
- done
+ eval $check || {
+ echo "skip $1 (failed \$($check))"
+ return
+ }
cmdline="TESTNAME=$testname ACCEL=$accel ./$TEST_DIR-run $kernel -smp $smp $opts"
if [ $verbose != 0 ]; then
--
2.6.4
next prev parent reply other threads:[~2015-12-14 21:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 21:24 [PATCH kvm-unit-tests 0/6] Improve the output of test runners Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 1/6] lib/report: allow test skipping Radim Krčmář
2015-12-14 22:00 ` Andrew Jones
2015-12-14 22:12 ` Andrew Jones
2015-12-15 12:54 ` Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 2/6] x86/*: report skipped tests Radim Krčmář
2015-12-14 22:07 ` Andrew Jones
2015-12-15 12:58 ` Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 3/6] x86/pmu: expect failure with nmi_watchdog Radim Krčmář
2015-12-14 22:05 ` Andrew Jones
2015-12-15 13:01 ` Radim Krčmář
2015-12-15 15:33 ` Andrew Jones
2015-12-14 21:24 ` Radim Krčmář [this message]
2015-12-14 22:11 ` [PATCH kvm-unit-tests 4/6] run_tests: generalize check Andrew Jones
2015-12-15 13:05 ` Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 5/6] x86/hyperv_synic: check for support before testing Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 6/6] run_tests: print summary Radim Krčmář
2015-12-14 22:20 ` [PATCH kvm-unit-tests 0/6] Improve the output of test runners Andrew Jones
2015-12-15 13:10 ` Radim Krčmář
2015-12-15 10:19 ` Paolo Bonzini
2015-12-15 13:13 ` Radim Krčmář
2015-12-15 15:37 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450128261-21170-5-git-send-email-rkrcmar@redhat.com \
--to=rkrcmar@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.