From: Jean-Michel Hautbois <jhautbois@gmail.com>
To: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: fbrozovic@gmail.com, alexander.stein@systec-electronic.com,
eric.nelson@boundarydevices.com,
gianlucarenzi@eurekelettronica.it, lars@metafoo.de,
tiwai@suse.com, perex@perex.cz, broonie@kernel.org,
lgirdwood@gmail.com,
Jean-Michel Hautbois <jean-michel.hautbois@veo-labs.com>
Subject: [PATCH] ASoC: sgtl5000: fix VAG power up timing
Date: Thu, 17 Dec 2015 11:07:23 +0100 [thread overview]
Message-ID: <1450346843-6700-1-git-send-email-jean-michel.hautbois@veo-labs.com> (raw)
When power up, a "pop" is heard on line-in and mic-in.
An analysis of the PCM shows it lasts ~400ms
and looks like a filter response.
VAG power up should be delayed by 400ms as VAG power down is.
Signed-off-by: Jean-Michel Hautbois <jean-michel.hautbois@veo-labs.com>
---
sound/soc/codecs/sgtl5000.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index f540f82..08b4046 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -189,6 +189,7 @@ static int power_vag_event(struct snd_soc_dapm_widget *w,
case SND_SOC_DAPM_POST_PMU:
snd_soc_update_bits(codec, SGTL5000_CHIP_ANA_POWER,
SGTL5000_VAG_POWERUP, SGTL5000_VAG_POWERUP);
+ msleep(400);
break;
case SND_SOC_DAPM_PRE_PMD:
--
2.6.4
next reply other threads:[~2015-12-17 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 10:07 Jean-Michel Hautbois [this message]
2015-12-18 12:15 ` Applied "ASoC: sgtl5000: fix VAG power up timing" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450346843-6700-1-git-send-email-jean-michel.hautbois@veo-labs.com \
--to=jhautbois@gmail.com \
--cc=alexander.stein@systec-electronic.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=eric.nelson@boundarydevices.com \
--cc=fbrozovic@gmail.com \
--cc=gianlucarenzi@eurekelettronica.it \
--cc=jean-michel.hautbois@veo-labs.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.