All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Goldstein <cardoe@cardoe.com>
To: xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Doug Goldstein <cardoe@cardoe.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH] build: convert CONFIG_COMPAT to Kconfig
Date: Fri, 18 Dec 2015 14:06:58 -0600	[thread overview]
Message-ID: <1450469218-24860-1-git-send-email-cardoe@cardoe.com> (raw)

Use the Kconfig generated CONFIG_COMPAT defines in the code base.

CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
This was previously Acked-by: Jan Beulich <jbeulich@suse.com> but then
there was a request to change it to xen/common/Kconfig from
xen/arch/x86/Kconfig. Unfortunately a small typo ('def_bool y' instead of
'bool') caused it to break on ARM. This resolves the issue and should be
ready to merge.
---
 config/x86_64.mk     | 1 -
 xen/arch/x86/Kconfig | 1 +
 xen/common/Kconfig   | 7 +++++++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/config/x86_64.mk b/config/x86_64.mk
index f12d549..85fa27c 100644
--- a/config/x86_64.mk
+++ b/config/x86_64.mk
@@ -2,7 +2,6 @@ CONFIG_X86 := y
 CONFIG_X86_64 := y
 CONFIG_X86_$(XEN_OS) := y
 
-CONFIG_COMPAT := y
 CONFIG_MIGRATE := y
 CONFIG_XCUTILS := y
 
diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 07e366d..7d2ed96 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -3,6 +3,7 @@ config X86_64
 
 config X86
 	def_bool y
+	select COMPAT
 	select HAS_ACPI
 	select HAS_CPUFREQ
 	select HAS_EHCI
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index 7d0e9a9..046e257 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -1,6 +1,13 @@
 
 menu "Common Features"
 
+config COMPAT
+	bool
+	help
+	  32-bit interface support on 64-bit Xen which is used for both
+	  HVM and PV guests. HVMLoader makes 32-bit hypercalls irrespective
+	  of the destination runmode of the guest.
+
 # Select HAS_DEVICE_TREE if device tree is supported
 config HAS_DEVICE_TREE
 	bool
-- 
2.4.10

             reply	other threads:[~2015-12-18 20:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 20:06 Doug Goldstein [this message]
2015-12-18 21:35 ` [PATCH] build: convert CONFIG_COMPAT to Kconfig Andrew Cooper
2015-12-18 21:49   ` Doug Goldstein
2015-12-18 22:09     ` Andrew Cooper
2015-12-20 13:42       ` Doug Goldstein
2015-12-20 15:47         ` Andrew Cooper
2015-12-21 11:32       ` Jan Beulich
2016-01-04 11:21         ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2015-12-15 15:23 [PATCH v8 28/28] " Jan Beulich
2015-12-16 12:00 ` [PATCH] " Doug Goldstein
2015-12-16 12:52   ` Jan Beulich
2015-12-16 17:01   ` Jan Beulich
2015-12-17 16:00     ` Doug Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450469218-24860-1-git-send-email-cardoe@cardoe.com \
    --to=cardoe@cardoe.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.