Re: [PATCH 26/28] libxl: spawns two QEMUs for HVM guests

From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 26/28] libxl: spawns two QEMUs for HVM guests
Date: Fri, 8 Jan 2016 14:52:41 +0000	[thread overview]
Message-ID: <1452264761.29416.44.camel@citrix.com> (raw)
In-Reply-To: <22159.51500.829264.401232@mariner.uk.xensource.com>

On Fri, 2016-01-08 at 14:35 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 26/28] libxl: spawns two QEMUs for HVM
> guests"):
> > On Tue, 2015-12-22 at 18:45 +0000, Ian Jackson wrote:
> > > @@ -440,6 +442,15 @@ static int
> > > domcreate_setdefault_dm_user(libxl__gc
> > > *gc,
> > > +    if (!libxl__dm_supported(gc, dm,
> > > libxl__dm_support_check__emulator_id)) {
> > > +        /* we don't want to run the pv backends as non-root because
> > > +         * device hotplug will no longer work. */
> > > +        LOG(WARN,
> > > + "Device model does not support split PV backends, running it as
> > > root");
> > > +        user = "root";
> > > +        goto found;
> > > +    }
> > 
> > Should this be a fatal error, unless b_info->device_model_user ==
> > "root"?
> 
> This is in the code which sets the default value if the configuration
> didn't specify one.

Oh yes, sorry for the noise.

> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel