All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Ricard <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	peterhuewe-Mmb7MZpHnFY@public.gmane.org
Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org,
	ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org,
	christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	christophe-h.ricard-qxv4g6HH51o@public.gmane.org,
	benoit.houyere-qxv4g6HH51o@public.gmane.org
Subject: [PATCH 07/12] tpm/st33zp24/spi: Improve st33zp24_spi_evaluate_latency
Date: Tue,  9 Feb 2016 10:26:56 +0100	[thread overview]
Message-ID: <1455010021-21927-8-git-send-email-christophe-h.ricard@st.com> (raw)
In-Reply-To: <1455010021-21927-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>

Add check in st33zp24_spi_evaluate_latency helping to diagnose if the chip
is present or in a bad state.

Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
---
 drivers/char/tpm/st33zp24/spi.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/spi.c
index 0af836a..7cabf1d 100644
--- a/drivers/char/tpm/st33zp24/spi.c
+++ b/drivers/char/tpm/st33zp24/spi.c
@@ -213,6 +213,11 @@ static int st33zp24_spi_evaluate_latency(void *phy_id)
 						&data, 1);
 		latency++;
 	}
+	if (status < 0)
+		return status;
+	if (latency == MAX_SPI_LATENCY)
+		return -ENODEV;
+
 	return latency - 1;
 } /* evaluate_latency() */
 
-- 
2.5.0


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140

  parent reply	other threads:[~2016-02-09  9:26 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09  9:26 [PATCH 00/12] tpm/st33zp24: Few code style and sanity fixes + acpi device probing support Christophe Ricard
     [not found] ` <1455010021-21927-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-09  9:26   ` [PATCH 01/12] tpm/st33zp24/spi: Remove nbr_dummy_bytes variable usage Christophe Ricard
     [not found]     ` <1455010021-21927-2-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 13:48       ` Jarkko Sakkinen
2016-02-09  9:26   ` [PATCH 02/12] tpm/st33zp24/spi: Use functions name with st33zp24_spi_ prefix Christophe Ricard
     [not found]     ` <1455010021-21927-3-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 13:50       ` Jarkko Sakkinen
2016-02-09  9:26   ` [PATCH 03/12] tpm/st33zp24/spi: Remove useless use of memcpy Christophe Ricard
     [not found]     ` <1455010021-21927-4-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 13:54       ` Jarkko Sakkinen
2016-02-09  9:26   ` [PATCH 04/12] tpm/st33zp24/spi: Remove field spi_xfer from st33zp24_spi_phy structure Christophe Ricard
     [not found]     ` <1455010021-21927-5-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 14:06       ` Jarkko Sakkinen
2016-02-09  9:26   ` [PATCH 05/12] tpm/st33zp24: Remove unneeded CONFIG_OF switches Christophe Ricard
     [not found]     ` <1455010021-21927-6-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 14:10       ` Jarkko Sakkinen
2016-02-09  9:26   ` [PATCH 06/12] tpm/st33zp24: Auto-select core module Christophe Ricard
     [not found]     ` <1455010021-21927-7-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 14:18       ` Jarkko Sakkinen
2016-02-09  9:26   ` Christophe Ricard [this message]
     [not found]     ` <1455010021-21927-8-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 14:22       ` [PATCH 07/12] tpm/st33zp24/spi: Improve st33zp24_spi_evaluate_latency Jarkko Sakkinen
2016-02-09  9:26   ` [PATCH 08/12] tpm/st33zp24: Extend Copyright headers Christophe Ricard
     [not found]     ` <1455010021-21927-9-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 14:22       ` Jarkko Sakkinen
2016-02-09  9:26   ` [PATCH 09/12] tpm/st33zp24: Add support for acpi probing for i2c device Christophe Ricard
     [not found]     ` <1455010021-21927-10-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 14:28       ` Jarkko Sakkinen
2016-02-09  9:26   ` [PATCH 10/12] tpm: st33zp24: Add support for acpi probing for spi device Christophe Ricard
     [not found]     ` <1455010021-21927-11-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 14:29       ` Jarkko Sakkinen
2016-02-09  9:27   ` [PATCH 11/12] tpm/st33zp24/i2c: Change xxx_request_resources header Christophe Ricard
     [not found]     ` <1455010021-21927-12-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 14:36       ` Jarkko Sakkinen
2016-02-09  9:27   ` [PATCH 12/12] tpm/st33zp24/spi: " Christophe Ricard
     [not found]     ` <1455010021-21927-13-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-11 14:44       ` Jarkko Sakkinen
2016-02-14  9:11   ` [PATCH 00/12] tpm/st33zp24: Few code style and sanity fixes + acpi device probing support Jarkko Sakkinen
     [not found]     ` <20160214091106.GA18761-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-14  9:41       ` Christophe Ricard
2016-02-18  7:12       ` Christophe Ricard
     [not found]         ` <56C56EED.1070801-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-18 14:46           ` Jarkko Sakkinen
     [not found]             ` <20160218144651.GA8472-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-18 21:03               ` Christophe Ricard
     [not found]                 ` <56C631A7.5040604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-19 15:03                   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455010021-21927-8-git-send-email-christophe-h.ricard@st.com \
    --to=christophe.ricard-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
    --cc=benoit.houyere-qxv4g6HH51o@public.gmane.org \
    --cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=jean-luc.blanc-qxv4g6HH51o@public.gmane.org \
    --cc=peterhuewe-Mmb7MZpHnFY@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.