All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, lgirdwood@gmail.com,
	Ramesh Babu <ramesh.babu@intel.com>,
	patches.audio@intel.com, broonie@kernel.org,
	Vinod Koul <vinod.koul@intel.com>,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: [PATCH v7 3/9] ASoC: hdac_hdmi: Fix to keep codec power active during enumeration.
Date: Wed, 17 Feb 2016 21:34:01 +0530	[thread overview]
Message-ID: <1455725047-7303-4-git-send-email-subhransu.s.prusty@intel.com> (raw)
In-Reply-To: <1455725047-7303-1-git-send-email-subhransu.s.prusty@intel.com>

From: Ramesh Babu <ramesh.babu@intel.com>

The codec power is turned OFF in the first explicit call to
pm_runtime_suspend to keep the i915 refcount balanced. During regular
operation, the power is turned ON/OFF in runtime PM handlers.

Signed-off-by: Ramesh Babu <ramesh.babu@intel.com>
Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/codecs/hdac_hdmi.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c
index f12af62..57ab212 100644
--- a/sound/soc/codecs/hdac_hdmi.c
+++ b/sound/soc/codecs/hdac_hdmi.c
@@ -1426,6 +1426,18 @@ static int hdac_hdmi_dev_probe(struct hdac_ext_device *edev)
 	INIT_LIST_HEAD(&hdmi_priv->pcm_list);
 	mutex_init(&hdmi_priv->pin_mutex);
 
+	/*
+	 * Turned off in the runtime_suspend during the first explicit
+	 * pm_runtime_suspend call.
+	 */
+	ret = snd_hdac_display_power(edev->hdac.bus, true);
+	if (ret < 0) {
+		dev_err(&edev->hdac.dev,
+			"Cannot turn on display power on i915 err: %d\n",
+			ret);
+		return ret;
+	}
+
 	ret = hdac_hdmi_parse_and_map_nid(edev, &hdmi_dais, &num_dais);
 	if (ret < 0) {
 		dev_err(&codec->dev,
-- 
1.9.1

  parent reply	other threads:[~2016-02-17 16:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 16:03 [PATCH v7 0/9] ASoC: hdac_hdmi: Update to HDMI driver Subhransu S. Prusty
2016-02-17 16:03 ` [PATCH v7 1/9] ASoC: hdac_hdmi: Fix possible memory leak in hw_params Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: hdac_hdmi: Fix possible memory leak in hw_params" to the asoc tree Mark Brown
2016-02-17 16:04 ` [PATCH v7 2/9] ASoC: hdac_hdmi: Don't fail in dai startup to make userland happy Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: hdac_hdmi: Don't fail in dai startup to make userland happy" to the asoc tree Mark Brown
2016-02-17 16:04 ` Subhransu S. Prusty [this message]
2016-02-17 16:04 ` [PATCH v7 4/9] ASoC: hdac_hdmi: Fix to reconfigure registers in runtime resume Subhransu S. Prusty
2016-02-19 15:55   ` Mark Brown
2016-02-17 16:04 ` [PATCH v7 5/9] ASoC: hdac_hdmi: Fix to wait for D3 before powering off codec Subhransu S. Prusty
2016-02-19 15:56   ` Mark Brown
2016-02-17 16:04 ` [PATCH v7 6/9] ASoC: hdac_hdmi: Add PM support Subhransu S. Prusty
2016-02-17 16:04 ` [PATCH v7 7/9] ASoC: Intel: Skylake: Fix possible memory corruption in codec dai dma params Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: Intel: Skylake: Fix possible memory corruption in codec dai dma params" to the asoc tree Mark Brown
2016-02-17 16:04 ` [PATCH v7 8/9] ASoC: Intel: Skylake: Add i915 enabling in skl probe Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: Intel: Skylake: Add i915 enabling in skl probe" to the asoc tree Mark Brown
2016-02-17 16:04 ` [PATCH v7 9/9] ASoC: Intel: Skylake: Add HDMI FE and BE cpu dais Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: Intel: Skylake: Add HDMI FE and BE cpu dais" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455725047-7303-4-git-send-email-subhransu.s.prusty@intel.com \
    --to=subhransu.s.prusty@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches.audio@intel.com \
    --cc=ramesh.babu@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.