From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: imre.deak@intel.com, Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Tune down init error message due to failure injection
Date: Fri, 18 Mar 2016 10:59:41 +0200 [thread overview]
Message-ID: <1458291581.23824.4.camel@linux.intel.com> (raw)
In-Reply-To: <1458253085.4847.32.camel@intel.com>
On pe, 2016-03-18 at 00:18 +0200, Imre Deak wrote:
> On Thu, 2016-03-17 at 22:14 +0000, Chris Wilson wrote:
> >
> > On Fri, Mar 18, 2016 at 12:09:30AM +0200, Imre Deak wrote:
> > >
> > > On Thu, 2016-03-17 at 21:48 +0000, Chris Wilson wrote:
> > > >
> > > > I would also like this to be the preferred
> > > > DRM_ERROR reporting mechanism i.e. anytime we emit an ERROR we
> > > > should
> > > > be
> > > > encouraging the user to file a bug, and do so in a user friendly
> > > > fashion.
> > > Ok, but only in i915 I assume. Should we also convert then all
> > > DRM_ERROR to dev_err - with an *ERROR* prefix - or still use
> > > DRM_ERROR?
> > Within i915. I am thinking along the lines that no DRM_ERROR should
> > exist that doesn't acknowlege that it is a user facing error message
> > (i.e. written in plain English and is informative, and includes a bug
> > reporting reference). So i915_report_error() or somesuch.
> Ok, will give it a go.
Daniel didn't want i915 debugging/erroring mechanisms to deviate from
core DRM. So I guess this would follow in the same category.
I'm all in for structuring a coherent debugging/error message logic and
functions for it and then everyone can follow the suit.
Regards, Joonas
>
> --Imre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-18 8:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 14:42 [PATCH] drm/i915: Tune down init error message due to failure injection Imre Deak
2016-03-17 15:12 ` Chris Wilson
2016-03-17 15:46 ` [PATCH v2] " Imre Deak
2016-03-17 15:55 ` Chris Wilson
2016-03-17 16:08 ` Imre Deak
2016-03-17 19:41 ` Chris Wilson
2016-03-17 19:50 ` Imre Deak
2016-03-17 20:44 ` Chris Wilson
2016-03-17 20:53 ` Imre Deak
2016-03-17 21:03 ` Chris Wilson
2016-03-17 21:10 ` Imre Deak
2016-03-17 21:48 ` Chris Wilson
2016-03-17 22:09 ` Imre Deak
2016-03-17 22:14 ` Chris Wilson
2016-03-17 22:18 ` Imre Deak
2016-03-18 8:59 ` Joonas Lahtinen [this message]
2016-03-18 9:15 ` Imre Deak
2016-03-21 9:28 ` Daniel Vetter
2016-03-21 15:12 ` Imre Deak
2016-03-24 13:11 ` Joonas Lahtinen
2016-03-29 9:26 ` Daniel Vetter
2016-03-18 9:26 ` Chris Wilson
2016-03-17 16:36 ` [PATCH v3] " Imre Deak
2016-03-18 1:09 ` [PATCH v4] " Imre Deak
2016-03-18 6:50 ` [PATCH v5] " Imre Deak
2016-03-18 7:58 ` Chris Wilson
2016-03-18 8:16 ` Imre Deak
2016-03-18 8:23 ` Chris Wilson
2016-03-18 8:46 ` [PATCH v6] " Imre Deak
2016-03-18 12:38 ` ✗ Fi.CI.BAT: failure for drm/i915: Tune down init error message due to failure injection (rev6) Patchwork
2016-03-18 13:29 ` Imre Deak
2016-03-18 13:42 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458291581.23824.4.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.