All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH 00/20] block: Implement writethrough in BlockBackend
Date: Fri, 18 Mar 2016 19:21:09 +0100	[thread overview]
Message-ID: <1458325289-17848-1-git-send-email-kwolf@redhat.com> (raw)

I already sent (and merged) patches that are meant to prevent users from
setting the writethrough option on non-root nodes, where we won't be able to
support the feature in the long term because we discovered that writethrough
mode only makes sense as a BlockBackend feature. The intention was to allow
moving the feature where it belongs in the following release.

However, moving the feature involves another few changes in behaviour in some
corner cases (most of which became only possible with patches after 2.5), so it
seems to be actually preferable to do the full thing now instead of having
behaviour changes in two consecutive releases.

This series removes (or is supposed to remove, at least) all traces of
writethrough handling from the BlockDriverState layer and implements it in
BlockBackend instead.

Kevin Wolf (20):
  block: Add bdrv_parse_cache_mode()
  qemu-nbd: Call blk_set_enable_write_cache() explicitly
  qemu-io: Call blk_set_enable_write_cache() explicitly
  qemu-img: Expand all BDRV_O_FLAGS uses
  qemu-img: Call blk_set_enable_write_cache() explicitly
  xen_disk: Call blk_set_enable_write_cache() explicitly
  block: blockdev_init(): Call blk_set_enable_write_cache() explicitly
  block: Always set writeback mode in blk_new_open()
  block: Handle flush error in bdrv_pwrite_sync()
  block: Move enable_write_cache to BB level
  block/qapi: Use blk_enable_write_cache()
  block: Introduce bdrv_co_writev_flags()
  iscsi: Support BDRV_REQ_FUA
  nbd: Support BDRV_REQ_FUA
  raw: Support BDRV_REQ_FUA
  block: Use bdrv_parse_cache_mode() in drive_init()
  qemu-io: Use bdrv_parse_cache_mode() in reopen_f()
  block: Remove bdrv_parse_cache_flags()
  block: Remove BDRV_O_CACHE_WB
  block: Remove bdrv_(set_)enable_write_cache()

 block.c                       |  78 +++++---------------------------
 block/backup.c                |   1 -
 block/block-backend.c         |  45 ++++++++++--------
 block/io.c                    |  15 ++++--
 block/iscsi.c                 |  24 +++-------
 block/mirror.c                |   1 -
 block/nbd-client.c            |  13 +++---
 block/nbd-client.h            |   2 +-
 block/nbd.c                   |  26 +++++++++--
 block/parallels.c             |   3 +-
 block/qapi.c                  |   7 +--
 block/qcow.c                  |   3 +-
 block/qcow2.c                 |   9 ++--
 block/qed.c                   |   3 +-
 block/raw_bsd.c               |  11 +++--
 block/sheepdog.c              |   5 +-
 block/vdi.c                   |   3 +-
 block/vhdx.c                  |   3 +-
 block/vmdk.c                  |   8 ++--
 block/vpc.c                   |   3 +-
 block/vvfat.c                 |   3 +-
 blockdev.c                    |  35 ++++++--------
 hw/block/xen_disk.c           |   5 +-
 include/block/block.h         |   8 ++--
 include/block/block_int.h     |   8 ++--
 include/block/qapi.h          |   3 +-
 qemu-img.c                    |  84 ++++++++++++++++++++--------------
 qemu-io-cmds.c                |  13 +++++-
 qemu-io.c                     |  21 +++++----
 qemu-nbd.c                    |   5 +-
 tests/qemu-iotests/051        |   2 +-
 tests/qemu-iotests/051.pc.out |  10 ++--
 tests/qemu-iotests/142        |  19 +++++---
 tests/qemu-iotests/142.out    | 103 ++++++++++++++++++++++++++++--------------
 34 files changed, 304 insertions(+), 278 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2016-03-18 18:21 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 18:21 Kevin Wolf [this message]
2016-03-18 18:21 ` [Qemu-devel] [PATCH 01/20] block: Add bdrv_parse_cache_mode() Kevin Wolf
2016-03-26 17:05   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 02/20] qemu-nbd: Call blk_set_enable_write_cache() explicitly Kevin Wolf
2016-03-26 17:09   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 03/20] qemu-io: " Kevin Wolf
2016-03-26 17:18   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 04/20] qemu-img: Expand all BDRV_O_FLAGS uses Kevin Wolf
2016-03-26 17:34   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 05/20] qemu-img: Call blk_set_enable_write_cache() explicitly Kevin Wolf
2016-03-26 17:54   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 06/20] xen_disk: " Kevin Wolf
2016-03-22 11:08   ` Stefano Stabellini
2016-03-26 17:59   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 07/20] block: blockdev_init(): " Kevin Wolf
2016-03-26 18:13   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 08/20] block: Always set writeback mode in blk_new_open() Kevin Wolf
2016-03-26 18:36   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 09/20] block: Handle flush error in bdrv_pwrite_sync() Kevin Wolf
2016-03-26 18:46   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 10/20] block: Move enable_write_cache to BB level Kevin Wolf
2016-03-26 19:54   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 11/20] block/qapi: Use blk_enable_write_cache() Kevin Wolf
2016-03-26 20:14   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 12/20] block: Introduce bdrv_co_writev_flags() Kevin Wolf
2016-03-26 20:24   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 13/20] iscsi: Support BDRV_REQ_FUA Kevin Wolf
2016-03-26 20:33   ` Max Reitz
2016-03-26 20:44   ` Max Reitz
2016-03-29 11:02     ` Kevin Wolf
2016-03-18 18:21 ` [Qemu-devel] [PATCH 14/20] nbd: " Kevin Wolf
2016-03-26 20:46   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 15/20] raw: " Kevin Wolf
2016-03-26 20:49   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 16/20] block: Use bdrv_parse_cache_mode() in drive_init() Kevin Wolf
2016-03-26 20:53   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f() Kevin Wolf
2016-03-26 21:05   ` Max Reitz
2016-03-29 10:16     ` Kevin Wolf
2016-03-18 18:21 ` [Qemu-devel] [PATCH 18/20] block: Remove bdrv_parse_cache_flags() Kevin Wolf
2016-03-26 21:06   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 19/20] block: Remove BDRV_O_CACHE_WB Kevin Wolf
2016-03-26 21:23   ` Max Reitz
2016-03-18 18:21 ` [Qemu-devel] [PATCH 20/20] block: Remove bdrv_(set_)enable_write_cache() Kevin Wolf
2016-03-26 21:25   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458325289-17848-1-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.