Re: [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option.

From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "baker.dylan.c@gmail.com" <baker.dylan.c@gmail.com>,
	"Vlad, Marius C" <marius.c.vlad@intel.com>
Cc: "Yates, Alexandra" <alexandra.yates@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option.
Date: Thu, 24 Mar 2016 01:52:38 +0000	[thread overview]
Message-ID: <1458784363.27320.205.camel@intel.com> (raw)
In-Reply-To: <145866448402.4301.10489534665657450658@alivia>

On Tue, 2016-03-22 at 09:34 -0700, Dylan Baker wrote:
> Quoting Vivi, Rodrigo (2016-03-21 19:00:10)
> > On Mon, 2016-03-21 at 12:53 +0200, Marius Vlad wrote:
> > > Isn't this as https://patchwork.freedesktop.org/series/4177/?
> > > 
> > > On Fri, Mar 18, 2016 at 07:02:11AM -0700, Rodrigo Vivi wrote:
> > > > The following piglit commit adds one option to overwrite files:
> > > > 
> > > > commit ec317ece07afdf9c8a26de04bdec8a94e5d7b2db
> > > > Author: Dylan Baker <baker.dylan.c@gmail.com>
> > > > Date:   Mon Feb 1 15:08:23 2016 -0800
> > > > 
> > > >     framework/programs/run.py: Add option for overwriting files
> > > > 
> > > > So our run-script.sh test that creates the directory before
> > > > executing
> > > > the tests were failing with:
> > > > 
> > > > "Fatal Error: Cannot overwrite existing folder w/o the -o /-
> > > > -overwrite option being sent"
> > > > 
> > > > I believe it took a while to notice that because many of us
> > > > never
> > > > upgrade the piglit. But also the risk with this patch is to
> > > > have an
> > > > environment
> > > > with the old piglit so the result will be:
> > > > piglit: error: unrecognized arguments: --overwrite
> > > 
> > > Maybe we can test against piglit version and use it accordingly.
> > 
> > Yeah, I wondered that... but apparently piglit doesn't return the
> > version...
> > The ugly way that came to my mind was something like:
> > 
> > $PIGLIT run --help | grep overwrite > /dev/null
> > if [ $? -eq 0 ]; then
> >  # use overwwrite
> > else
> >  # keep the old
> > fi
> > 
> > any non-ugly idea?
> > 
> 
> I was just thinking that it was stupid that piglit doesn't have a
> version of any kind. I'm planning to add one although it will only be
> a
> git sha and maybe a date since piglit intentionally doesn't have
> major
> or minor version numbers.

Thanks Dylan.... But how will you handle the piglig installed in
/usr/local/bin? Maybe we can have one version in our piglit dir inside
igt but another version in the system what could be different and
misslead this check.

> 
> Dylan
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx