From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: yauhen.kharuzhy@zavadatar.com, dsterba@suse.cz
Subject: [PATCH 07/13] btrfs: add check not to mount a spare device
Date: Sat, 2 Apr 2016 09:30:45 +0800 [thread overview]
Message-ID: <1459560651-14809-8-git-send-email-anand.jain@oracle.com> (raw)
In-Reply-To: <1459560651-14809-1-git-send-email-anand.jain@oracle.com>
Spare devices can be scanned but shouldn't be mountable.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Tested-by: Austin S. Hemmelgarn <ahferroin7@gmail.com>
---
fs/btrfs/disk-io.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 7f02f1766037..b99329e37965 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2806,6 +2806,14 @@ int open_ctree(struct super_block *sb,
goto fail_alloc;
}
+ if (btrfs_super_incompat_flags(disk_super) &
+ BTRFS_FEATURE_INCOMPAT_SPARE_DEV) {
+ /*You can only scan a spare device but not mount*/
+ printk(KERN_ERR "BTRFS: You can't mount a spare device\n");
+ err = -ENOTSUPP;
+ goto fail_alloc;
+ }
+
/*
* Needn't use the lock because there is no other task which will
* update the flag.
--
2.7.0
next prev parent reply other threads:[~2016-04-02 1:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 1:30 [PATCH 00/13 v3] Introduce device state 'failed', Hot spare and Auto replace Anand Jain
2016-04-02 1:30 ` [PATCH 01/13] btrfs: Introduce a new function to check if all chunks a OK for degraded mount Anand Jain
2016-04-02 1:30 ` [PATCH 02/13] btrfs: Do per-chunk check for mount time check Anand Jain
2016-04-02 1:30 ` [PATCH 03/13] btrfs: Do per-chunk degraded check for remount Anand Jain
2016-04-02 1:30 ` [PATCH 04/13] btrfs: Allow barrier_all_devices to do per-chunk device check Anand Jain
2016-04-02 1:30 ` [PATCH 05/13] btrfs: Cleanup num_tolerated_disk_barrier_failures Anand Jain
2016-04-02 1:30 ` [PATCH 06/13] btrfs: introduce BTRFS_FEATURE_INCOMPAT_SPARE_DEV Anand Jain
2016-04-02 1:30 ` Anand Jain [this message]
2016-04-02 1:30 ` [PATCH 08/13] btrfs: support btrfs dev scan for spare device Anand Jain
2016-04-02 1:30 ` [PATCH 09/13] btrfs: provide framework to get and put a " Anand Jain
2016-04-02 1:30 ` [PATCH 10/13] btrfs: introduce helper functions to perform hot replace Anand Jain
2016-04-02 5:40 ` kbuild test robot
2016-04-07 20:00 ` Yauhen Kharuzhy
2016-04-08 3:58 ` Anand Jain
2016-04-08 22:05 ` Yauhen Kharuzhy
2016-04-12 14:16 ` Anand Jain
2016-04-02 1:30 ` [PATCH 11/13] btrfs: introduce device dynamic state transition to offline or failed Anand Jain
2016-04-02 1:30 ` [PATCH 12/13] btrfs: check device for critical errors and mark failed Anand Jain
2016-04-02 1:30 ` [PATCH 13/13] btrfs: check for failed device and hot replace Anand Jain
2016-04-04 0:00 ` [PATCH 00/13 v3] Introduce device state 'failed', Hot spare and Auto replace Kai Krakow
2016-04-04 4:45 ` Duncan
2016-04-04 6:09 ` Duncan
2016-04-04 20:15 ` Kai Krakow
2016-04-05 3:02 ` Duncan
2016-04-04 6:19 ` Anand Jain
2016-04-04 20:07 ` Kai Krakow
2016-04-12 14:15 [PATCH v4 00/13] Introduce device state 'failed', spare device and auto replace Anand Jain
2016-04-12 14:15 ` [PATCH 07/13] btrfs: add check not to mount a spare device Anand Jain
2016-04-18 11:31 [PATCH v5 00/13] Introduce device state 'failed', spare device and auto replace Anand Jain
2016-04-18 11:31 ` [PATCH 07/13] btrfs: add check not to mount a spare device Anand Jain
2016-05-10 14:01 [PATCH v6 00/13] Introduce device state 'failed', spare device and auto replace Anand Jain
2016-05-10 14:01 ` [PATCH 07/13] btrfs: add check not to mount a spare device Anand Jain
2016-05-10 14:09 [PATCH v6 00/13] Introduce device state 'failed', spare device and auto replace Anand Jain
2016-05-10 14:09 ` [PATCH 07/13] btrfs: add check not to mount a spare device Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459560651-14809-8-git-send-email-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=yauhen.kharuzhy@zavadatar.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.