From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 4/4] clk: renesas: cpg-mssr: Use always-on governor for Clock Domain
Date: Tue, 26 Apr 2016 09:09:42 +0200 [thread overview]
Message-ID: <1461654582-668-5-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1461654582-668-1-git-send-email-geert+renesas@glider.be>
As a pure Clock Domain does not have the concept of powering the domain
itself, the CPG/MSTP driver does not provide power_off() and power_on()
callbacks.
However, the genpd core may still perform a dummy power down, causing
/sys/kernel/debug/pm_genpd/pm_genpd_summary to report the domain's
status being "off-0".
Use the always-on governor to make sure the domain is never powered
down, and always shows up as "on" in pm_genpd_summary.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/clk/renesas/renesas-cpg-mssr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index 0d595311c659a741..210cd744a7a97bbd 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -495,7 +495,7 @@ static int __init cpg_mssr_add_clk_domain(struct device *dev,
genpd->flags = GENPD_FLAG_PM_CLK;
genpd->attach_dev = cpg_mssr_attach_dev;
genpd->detach_dev = cpg_mssr_detach_dev;
- pm_genpd_init(genpd, &simple_qos_governor, false);
+ pm_genpd_init(genpd, &pm_domain_always_on_gov, false);
cpg_mssr_clk_domain = pd;
of_genpd_add_provider_simple(np, genpd);
--
1.9.1
next prev parent reply other threads:[~2016-04-26 7:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 7:09 [PATCH 0/4] clk: renesas: Clock Domain fixes Geert Uytterhoeven
2016-04-26 7:09 ` [PATCH 1/4] clk: renesas: mstp: Postpone call to pm_genpd_init() Geert Uytterhoeven
2016-04-26 7:09 ` [PATCH 2/4] clk: renesas: mstp: Use always-on governor for Clock Domain Geert Uytterhoeven
2016-04-27 13:59 ` Ulf Hansson
2016-04-27 14:04 ` Geert Uytterhoeven
2016-04-27 14:07 ` Ulf Hansson
2016-04-26 7:09 ` [PATCH 3/4] clk: renesas: cpg-mssr: Postpone call to pm_genpd_init() Geert Uytterhoeven
2016-04-26 7:09 ` Geert Uytterhoeven [this message]
2016-04-26 7:33 ` [PATCH 0/4] clk: renesas: Clock Domain fixes Laurent Pinchart
2016-04-27 14:06 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461654582-668-5-git-send-email-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=khilman@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.