From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: [PATCH v2 16/20] drm: omapdrm: Remove unused parameter from omap_drm_irq handler
Date: Tue, 7 Jun 2016 02:42:21 +0300 [thread overview]
Message-ID: <1465256545-533-17-git-send-email-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <1465256545-533-1-git-send-email-laurent.pinchart@ideasonboard.com>
The only omap_drm_irq handler doesn't use the irqstatus parameter passed
to the function. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v1:
- New patch
---
drivers/gpu/drm/omapdrm/omap_drv.h | 2 +-
drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h
index e15f6b384f65..5200fde1f38e 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.h
+++ b/drivers/gpu/drm/omapdrm/omap_drv.h
@@ -59,7 +59,7 @@ struct omap_drm_irq {
struct list_head node;
uint32_t irqmask;
bool registered;
- void (*irq)(struct omap_drm_irq *irq, uint32_t irqstatus);
+ void (*irq)(struct omap_drm_irq *irq);
};
/* For KMS code that needs to wait for a certain # of IRQs:
diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c
index c14530922f42..058ffdc0244d 100644
--- a/drivers/gpu/drm/omapdrm/omap_irq.c
+++ b/drivers/gpu/drm/omapdrm/omap_irq.c
@@ -82,7 +82,7 @@ struct omap_irq_wait {
static DECLARE_WAIT_QUEUE_HEAD(wait_event);
-static void wait_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
+static void wait_irq(struct omap_drm_irq *irq)
{
struct omap_irq_wait *wait =
container_of(irq, struct omap_irq_wait, irq);
@@ -248,7 +248,7 @@ static irqreturn_t omap_irq_handler(int irq, void *arg)
list_for_each_entry_safe(handler, n, &priv->irq_list, node) {
if (handler->irqmask & irqstatus) {
spin_unlock_irqrestore(&list_lock, flags);
- handler->irq(handler, handler->irqmask & irqstatus);
+ handler->irq(handler);
spin_lock_irqsave(&list_lock, flags);
}
}
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-06 23:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 23:42 [PATCH v2 00/20] OMAP DRM fixes and improvements Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 01/20] drm: omapdrm: fb: Limit number of planes per framebuffer to two Laurent Pinchart
2016-06-10 11:58 ` Tomi Valkeinen
2016-06-06 23:42 ` [PATCH v2 02/20] drm: omapdrm: fb: Use format information provided by the DRM core Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 03/20] drm: omapdrm: fb: Simplify objects lookup when creating framebuffer Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 04/20] drm: omapdrm: fb: Simplify mode command checks " Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 05/20] drm: omapdrm: fb: Turn framebuffer creation error messages into debug Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 06/20] drm: omapdrm: Handle FIFO underflow IRQs internally Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 07/20] drm: omapdrm: Handle CRTC error IRQs directly Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 08/20] drm: omapdrm: Handle OCP error IRQ directly Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 09/20] drm: omapdrm: Use atomic state instead of local device state Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 10/20] drm: omapdrm: Only commit planes on active CRTCs Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 11/20] drm: omapdrm: Check DSS manager state in the enable/disable helpers Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 12/20] drm: omapdrm: Prevent processing the same event multiple times Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 13/20] drm: omapdrm: Use a spinlock to protect the CRTC pending flag Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 14/20] drm: omapdrm: Keep vblank interrupt enabled while CRTC is active Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 15/20] drm: omapdrm: Don't expose the omap_irq_(un)register() functions Laurent Pinchart
2016-06-06 23:42 ` Laurent Pinchart [this message]
2016-06-06 23:42 ` [PATCH v2 17/20] drm: omapdrm: Don't call DISPC power handling in IRQ wait functions Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 18/20] drm: omapdrm: Make pipe2vbl function static Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 19/20] drm: omapdrm: Simplify IRQ wait implementation Laurent Pinchart
2016-06-06 23:42 ` [PATCH v2 20/20] drm: omapdrm: Remove global variables Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465256545-533-17-git-send-email-laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.