All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akshu Agrawal <akshu.agrawal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, daniel.vetter@intel.com,
	Akshu Agrawal <akshu.agrawal@intel.com>,
	shobhit.kumar@intel.com
Subject: [PATCH 1/2] Revert "drm/i915: Workaround CHV pipe C cursor fail"
Date: Wed,  8 Jun 2016 13:57:43 +0530	[thread overview]
Message-ID: <1465374464-7473-1-git-send-email-akshu.agrawal@intel.com> (raw)

This reverts commit ef8dd37af85a8f37ca3a29074647511e52c56181.

Will use cropped cursor image for -ve co-ordinates instead of using
swcursor. Advantages of cropped cursor being, it will work for non X11
based platform like Chrome and also will use hwcursor.

Signed-off-by: Akshu Agrawal <akshu.agrawal@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 12ff795..bca9245 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14287,7 +14287,6 @@ intel_check_cursor_plane(struct drm_plane *plane,
 	struct drm_crtc *crtc = crtc_state->base.crtc;
 	struct drm_framebuffer *fb = state->base.fb;
 	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
-	enum pipe pipe = to_intel_plane(plane)->pipe;
 	unsigned stride;
 	int ret;
 
@@ -14321,22 +14320,6 @@ intel_check_cursor_plane(struct drm_plane *plane,
 		return -EINVAL;
 	}
 
-	/*
-	 * There's something wrong with the cursor on CHV pipe C.
-	 * If it straddles the left edge of the screen then
-	 * moving it away from the edge or disabling it often
-	 * results in a pipe underrun, and often that can lead to
-	 * dead pipe (constant underrun reported, and it scans
-	 * out just a solid color). To recover from that, the
-	 * display power well must be turned off and on again.
-	 * Refuse the put the cursor into that compromised position.
-	 */
-	if (IS_CHERRYVIEW(plane->dev) && pipe == PIPE_C &&
-	    state->visible && state->base.crtc_x < 0) {
-		DRM_DEBUG_KMS("CHV cursor C not allowed to straddle the left screen edge\n");
-		return -EINVAL;
-	}
-
 	return 0;
 }
 
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2016-06-08  8:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  8:27 Akshu Agrawal [this message]
2016-06-08  8:27 ` [PATCH 2/2] drm/i915: Crop cursor image for CHV pipe C cursor issue Akshu Agrawal
2016-06-08  8:40   ` Daniel Vetter
2016-06-08 10:18     ` Dave Gordon
2016-06-09 17:03       ` Daniel Vetter
2016-06-10  9:44     ` Agrawal, Akshu
2016-06-13 14:22       ` Daniel Vetter
2016-06-27  9:09         ` Shobhit Kumar
2016-06-28 12:27         ` [RFC] drm/i915/chv: Clip cursor for CHV pipe C HW Cursor pos < 0 Shobhit Kumar
2016-06-28 12:32           ` Shobhit Kumar
2016-06-29 12:54           ` [RFC v2] " Shobhit Kumar
2016-06-29 13:02             ` Shobhit Kumar
2016-07-01  8:00             ` Shobhit Kumar
2016-07-08  9:01             ` Shobhit Kumar
2016-06-08  8:51   ` [PATCH 2/2] drm/i915: Crop cursor image for CHV pipe C cursor issue kbuild test robot
2016-06-08 11:09   ` kbuild test robot
2016-06-08  8:31 ` ✗ Ro.CI.BAT: failure for series starting with [1/2] Revert "drm/i915: Workaround CHV pipe C cursor fail" Patchwork
2016-06-28 13:04 ` ✗ Ro.CI.BAT: failure for series starting with [1/2] Revert "drm/i915: Workaround CHV pipe C cursor fail" (rev2) Patchwork
2016-06-29 13:20 ` ✓ Ro.CI.BAT: success for series starting with [1/2] Revert "drm/i915: Workaround CHV pipe C cursor fail" (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465374464-7473-1-git-send-email-akshu.agrawal@intel.com \
    --to=akshu.agrawal@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=shobhit.kumar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.