From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH] ndctl: make completion smarter wrt mode/type/idle options
Date: Mon, 27 Jun 2016 21:18:57 +0000 [thread overview]
Message-ID: <1467062314.7176.14.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4jpikCiOGyhoZZ70cWr9BAZibriGtNPJbQ1BeedXjJM2g@mail.gmail.com>
On Mon, 2016-06-27 at 14:13 -0700, Dan Williams wrote:
> On Mon, Jun 27, 2016 at 1:43 PM, Vishal Verma <vishal.l.verma@intel.co
> m> wrote:
> >
> > Add three new 'filters' for mode, type, and idle.
> >
> > 'mode' and 'type' work with each other to prevent a blk namespace
> > from
> > showing modes like 'dax' or 'memory', or if those modes are
> > specified,
> > then limiting 'type' to 'pmem'.
> >
> > Also show completions for --map= only if mode is 'memory'.
> --map= is also valid when the mode is 'dax'.
>
> There's also an assumption in the --reconfig= case for
> 'create-namespace' that parameters are inherited from the target
> namespace. For example, it might be surprising that completions are
> not provided for --map= when the mode is implied by the provided
> namespace.
Good point - I guess then it makes sense to drop the checking entirely
for --map.. I'll send a v2.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2016-06-27 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 20:43 [ndctl PATCH] ndctl: make completion smarter wrt mode/type/idle options Vishal Verma
2016-06-27 21:13 ` Dan Williams
2016-06-27 21:18 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467062314.7176.14.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.