All of lore.kernel.org
 help / color / mirror / Atom feed
From: <andros@netapp.com>
To: <trond.myklebust@primarydata.com>
Cc: <anna.schumaker@netapp.com>, <linux-nfs@vger.kernel.org>,
	Andy Adamson <andros@netapp.com>
Subject: [PATCH Version 7 2/8] NFS refactor nfs4_match_clientids
Date: Wed, 27 Jul 2016 14:43:14 -0400	[thread overview]
Message-ID: <1469645000-19791-3-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1469645000-19791-1-git-send-email-andros@netapp.com>

From: Andy Adamson <andros@netapp.com>

For session trunking, to compare nfs41_exchange_id_res with
exiting nfs_client.

Signed-off-by: Andy Adamson <andros@netapp.com>
---
 fs/nfs/nfs4client.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c
index 8d7d08d..d77a1ad 100644
--- a/fs/nfs/nfs4client.c
+++ b/fs/nfs/nfs4client.c
@@ -562,15 +562,15 @@ out:
 /*
  * Returns true if the client IDs match
  */
-static bool nfs4_match_clientids(struct nfs_client *a, struct nfs_client *b)
+static bool nfs4_match_clientids(u64 a, u64 b)
 {
-	if (a->cl_clientid != b->cl_clientid) {
+	if (a != b) {
 		dprintk("NFS: --> %s client ID %llx does not match %llx\n",
-			__func__, a->cl_clientid, b->cl_clientid);
+			__func__, a, b);
 		return false;
 	}
 	dprintk("NFS: --> %s client ID %llx matches %llx\n",
-		__func__, a->cl_clientid, b->cl_clientid);
+		__func__, a, b);
 	return true;
 }
 
@@ -650,7 +650,7 @@ int nfs41_walk_client_list(struct nfs_client *new,
 		if (pos->cl_cons_state != NFS_CS_READY)
 			continue;
 
-		if (!nfs4_match_clientids(pos, new))
+		if (!nfs4_match_clientids(pos->cl_clientid, new->cl_clientid))
 			continue;
 
 		/*
-- 
1.8.3.1


  parent reply	other threads:[~2016-07-27 18:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27 18:43 [PATCH Version 7 0/8] pNFS file layout session trunking andros
2016-07-27 18:43 ` [PATCH Version 7 1/8] NFS setup async exchange_id andros
2016-07-27 18:43 ` andros [this message]
2016-07-27 18:43 ` [PATCH Version 7 3/8] NFS refactor nfs4_check_serverowner_major_id andros
2016-07-27 18:43 ` [PATCH Version 7 4/8] NFS detect session trunking andros
2016-08-04 18:51   ` Anna Schumaker
2016-07-27 18:43 ` [PATCH Version 7 5/8] SUNRPC add remove xprt flag to rpc_task_release_client andros
2016-08-04 19:02   ` Anna Schumaker
2016-08-05 21:53   ` Trond Myklebust
2016-07-27 18:43 ` [PATCH Version 7 6/8] SUNRPC add an RPC null call to test session trunking connection andros
2016-08-04 19:26   ` Anna Schumaker
2016-08-05 16:41     ` Adamson, Andy
2016-08-05 18:08       ` Anna Schumaker
2016-07-27 18:43 ` [PATCH Version 7 7/8] NFS test session trunking with exchange id andros
2016-08-05 17:34   ` Trond Myklebust
2016-08-05 18:13     ` Adamson, Andy
2016-07-27 18:43 ` [PATCH Version 7 8/8] NFS pnfs data server multipath session trunking andros
2016-08-05 22:05   ` Trond Myklebust
2016-08-08 19:57     ` Adamson, Andy
2016-08-08 20:18       ` Trond Myklebust
  -- strict thread matches above, loose matches on Subject: below --
2016-07-27 18:39 [PATCH Version 7 0/8] pNFS file layout " andros
2016-07-27 18:39 ` [PATCH Version 7 2/8] NFS refactor nfs4_match_clientids andros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469645000-19791-3-git-send-email-andros@netapp.com \
    --to=andros@netapp.com \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.