All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, groug@kaod.org
Cc: agraf@suse.de, lvivier@redhat.com, thuth@redhat.com,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 01/13] pseries: Remove unused callbacks from sPAPR VIO bus state
Date: Thu, 20 Oct 2016 16:11:58 +1100	[thread overview]
Message-ID: <1476940330-27705-2-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1476940330-27705-1-git-send-email-david@gibson.dropbear.id.au>

The original QOMification of the spapr VIO devices in 3954d33 "spapr:
convert to QEMU Object Model (v2)" moved some callbacks from the
VIOsPAPRBus structure to the VIOsPAPRDeviceClass.  Except, that it
forgot to actually remove them from the VIOsPAPRBus structure (which
still exists, though it doesn't fulfill quite the same function as it
did pre-QOM).

This patch removes those now unused callback fields.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 include/hw/ppc/spapr_vio.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/hw/ppc/spapr_vio.h b/include/hw/ppc/spapr_vio.h
index 40d0e5f..0b025fd 100644
--- a/include/hw/ppc/spapr_vio.h
+++ b/include/hw/ppc/spapr_vio.h
@@ -76,8 +76,6 @@ struct VIOsPAPRDevice {
 struct VIOsPAPRBus {
     BusState bus;
     uint32_t next_reg;
-    int (*init)(VIOsPAPRDevice *dev);
-    int (*devnode)(VIOsPAPRDevice *dev, void *fdt, int node_off);
 };
 
 extern VIOsPAPRBus *spapr_vio_bus_init(void);
-- 
2.7.4

  reply	other threads:[~2016-10-20  5:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20  5:11 [Qemu-devel] [PATCH 00/13] pseries: Consolidate guest device tree construction David Gibson
2016-10-20  5:11 ` David Gibson [this message]
2016-10-20  6:55   ` [Qemu-devel] [PATCH 01/13] pseries: Remove unused callbacks from sPAPR VIO bus state Thomas Huth
2016-10-20  5:11 ` [Qemu-devel] [PATCH 02/13] pseries: Split device tree construction from device tree load David Gibson
2016-10-20  7:03   ` Thomas Huth
2016-10-21  1:24     ` David Gibson
2016-10-20  5:12 ` [Qemu-devel] [PATCH 03/13] pseries: Remove rtas_addr and fdt_addr fields from machinestate David Gibson
2016-10-20  5:12 ` [Qemu-devel] [PATCH 04/13] pseries: Make spapr_create_fdt_skel() get information from machine state David Gibson
2016-10-20  7:19   ` Thomas Huth
2016-10-20  5:12 ` [Qemu-devel] [PATCH 05/13] pseries: Move adding of fdt reserve map entries David Gibson
2016-10-20  5:12 ` [Qemu-devel] [PATCH 06/13] pseries: Consolidate RTAS loading David Gibson
2016-10-20  5:12 ` [Qemu-devel] [PATCH 07/13] spapr: Move construction of /interrupt-controller fdt node David Gibson
2016-10-20  7:27   ` Thomas Huth
2016-10-20  5:12 ` [Qemu-devel] [PATCH 08/13] spapr: Consolidate construction of /chosen device tree node David Gibson
2016-10-20  7:48   ` Thomas Huth
2016-10-20  7:49   ` Thomas Huth
2016-10-21  1:41     ` David Gibson
2016-10-20  5:12 ` [Qemu-devel] [PATCH 09/13] pseries: Consolidate construction of /rtas " David Gibson
2016-10-20  8:39   ` Thomas Huth
2016-10-20  5:12 ` [Qemu-devel] [PATCH 10/13] spapr: Move /event-sources construction to spapr_build_fdt() David Gibson
2016-10-20  8:42   ` Thomas Huth
2016-10-20  5:12 ` [Qemu-devel] [PATCH 11/13] spapr: Move /hypervisor node construction to fdt_build_fdt() David Gibson
2016-10-20  8:44   ` Thomas Huth
2016-10-20  5:12 ` [Qemu-devel] [PATCH 12/13] spapr: Consolidate construction of /vdevice device tree node David Gibson
2016-10-20  8:49   ` Thomas Huth
2016-10-20  5:12 ` [Qemu-devel] [PATCH 13/13] spapr: Remove spapr_create_fdt_skel() David Gibson
2016-10-20  8:54   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476940330-27705-2-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.