Re: [PATCH v2] virtio-gpu: fix vblank events

From: Gerd Hoffmann <kraxel@redhat.com>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: Dave Airlie <airlied@redhat.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] virtio-gpu: fix vblank events
Date: Thu, 03 Nov 2016 09:35:57 +0100	[thread overview]
Message-ID: <1478162157.19057.6.camel@redhat.com> (raw)
In-Reply-To: <20161102220018.GB3327@joana>

  Hi,

Dave, that is the only fix needed for for 4.9, can you pick it up
directly?  Otherwise I can prepare a single-patch pull request with
it ...

thanks,
  Gerd

On Mi, 2016-11-02 at 16:00 -0600, Gustavo Padovan wrote:
> ping
> 
> 2016-10-18 Gustavo Padovan <gustavo@padovan.org>:
> 
> > From: Gerd Hoffmann <kraxel@redhat.com>
> > 
> > virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and
> > because of that it must be called for disabled planes too.  Ask
> > drm_atomic_helper_commit_planes to do that.
> > 
> > v2: update to use new drm_atomic_helper_commit_planes() API.
> > 
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > ---
> >  drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
> > index 6848651..64facc8 100644
> > --- a/drivers/gpu/drm/virtio/virtgpu_display.c
> > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
> > @@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
> >  
> >  	drm_atomic_helper_commit_modeset_disables(dev, state);
> >  	drm_atomic_helper_commit_modeset_enables(dev, state);
> > -	drm_atomic_helper_commit_planes(dev, state,
> > -					DRM_PLANE_COMMIT_ACTIVE_ONLY);
> > +	drm_atomic_helper_commit_planes(dev, state, 0);
> >  
> >  	drm_atomic_helper_commit_hw_done(state);
> >  
> > -- 
> > 2.5.5
> > 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel