From: Jeff Layton <jlayton@redhat.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: "Yan, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH 1/4] ceph: fix endianness of getattr mask in ceph_d_revalidate
Date: Thu, 12 Jan 2017 12:16:32 -0500 [thread overview]
Message-ID: <1484241392.8506.4.camel@redhat.com> (raw)
In-Reply-To: <CAOi1vP8CMkXOj_wFekA-8Az_=boMg6Oz4-Fho6C9jt6XtrVKiw@mail.gmail.com>
On Thu, 2017-01-12 at 17:43 +0100, Ilya Dryomov wrote:
> On Thu, Jan 12, 2017 at 5:12 PM, Jeff Layton <jlayton@redhat.com> wrote:
> > fs/ceph/dir.c:1248:50: warning: incorrect type in assignment (different base types)
> > fs/ceph/dir.c:1248:50: expected restricted __le32 [usertype] mask
> > fs/ceph/dir.c:1248:50: got int [signed] [assigned] mask
>
> This one is missing "sparse says" ;)
>
> Thanks,
Oops! Fixed in my tree, which is here, btw:
git://git.samba.org/jlayton/linux.git
...in my ceph-4.10 branch.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2017-01-12 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 16:12 [PATCH 0/4] ceph: endianness fixes and sparse warning fixes Jeff Layton
2017-01-12 16:12 ` [PATCH 1/4] ceph: fix endianness of getattr mask in ceph_d_revalidate Jeff Layton
2017-01-12 16:43 ` Ilya Dryomov
2017-01-12 17:16 ` Jeff Layton [this message]
2017-01-12 16:12 ` [PATCH 2/4] ceph: fix endianness bug in frag_tree_split_cmp Jeff Layton
2017-01-12 16:12 ` [PATCH 3/4] ceph: fix bogus endianness change in ceph_ioctl_set_layout Jeff Layton
2017-01-12 16:12 ` [PATCH 4/4] ceph: fix bad endianness handling in parse_reply_info_extra Jeff Layton
2017-01-12 16:23 ` [PATCH 0/4] ceph: endianness fixes and sparse warning fixes Sage Weil
2017-01-13 12:36 ` Jeff Layton
2017-01-17 18:26 ` David Disseldorp
2017-01-17 18:28 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484241392.8506.4.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=sage@redhat.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.