From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
Brian King <brking@linux.vnet.ibm.com>
Cc: Anton Blanchard <anton@samba.org>,
james.smart@broadcom.com, dick.kennedy@broadcom.com,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
jk@ozlabs.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: Add shutdown method for kexec
Date: Tue, 14 Feb 2017 14:39:14 +1100 [thread overview]
Message-ID: <1487043554.23576.17.camel@kernel.crashing.org> (raw)
In-Reply-To: <874lzx32yd.fsf@xmission.com>
On Tue, 2017-02-14 at 15:45 +1300, Eric W. Biederman wrote:
> The only difference ever that should exist between shutdown and remove
> is do you clean up kernel data structures. The shutdown method is
> allowed to skip the cleanup up kernel data structures that the remove
> method needs to make.
>
> Assuming the kernel does not have corrupted data structures I don't see
> any practical reason for distinguishing between the two. There may be
> some real world gotchas we have to deal with but semantically I don't
> see any concerns.
We had historical additions to shutdown actually shutting things down,
like spinning platters down to park disk heads, switching devices
into D3 on some systems, etc... that remove never had (and we don't
want for kexec).
Cheers,
Ben.
next prev parent reply other threads:[~2017-02-14 3:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 21:49 [PATCH] scsi: lpfc: Add shutdown method for kexec Anton Blanchard
2017-02-12 23:14 ` Benjamin Herrenschmidt
2017-02-12 23:47 ` Anton Blanchard
2017-02-13 0:21 ` Eric W. Biederman
2017-02-13 1:01 ` Benjamin Herrenschmidt
2017-02-13 21:57 ` Brian King
2017-02-14 2:04 ` Benjamin Herrenschmidt
2017-02-14 14:56 ` Brian King
2017-02-15 2:44 ` Eric W. Biederman
2017-02-14 2:45 ` Eric W. Biederman
2017-02-14 3:39 ` Benjamin Herrenschmidt [this message]
2017-03-06 14:52 ` Mauricio Faria de Oliveira
2017-03-07 3:46 ` Martin K. Petersen
2017-03-07 5:24 ` Benjamin Herrenschmidt
2017-03-07 12:51 ` Mauricio Faria de Oliveira
2017-03-08 1:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487043554.23576.17.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=brking@linux.vnet.ibm.com \
--cc=dick.kennedy@broadcom.com \
--cc=ebiederm@xmission.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jk@ozlabs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.