Re: [PATCH 1/9] gpu: ipu-v3: remove AXI ID setting for IC channel

From: Philipp Zabel <p.zabel@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	patchwork-lst@pengutronix.de, Rob Herring <robh+dt@kernel.org>,
	kernel@pengutronix.de
Subject: Re: [PATCH 1/9] gpu: ipu-v3: remove AXI ID setting for IC channel
Date: Mon, 20 Feb 2017 14:04:10 +0100	[thread overview]
Message-ID: <1487595850.3878.3.camel@pengutronix.de> (raw)
In-Reply-To: <20170217182830.32618-2-l.stach@pengutronix.de>

On Fri, 2017-02-17 at 19:28 +0100, Lucas Stach wrote:
> This is a pretty minor optimization for the IC channel to get
> out-of-order AXI returns, but clashes with the AXI ID assignment
> that needs to be done for the display channels on QuadPlus.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/gpu/ipu-v3/ipu-image-convert.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c
> index 805b6fa7b5f4..5e3cc6bd98fc 100644
> --- a/drivers/gpu/ipu-v3/ipu-image-convert.c
> +++ b/drivers/gpu/ipu-v3/ipu-image-convert.c
> @@ -671,8 +671,6 @@ static void init_idmac_channel(struct ipu_image_convert_ctx *ctx,
>  	ipu_ic_task_idma_init(chan->ic, channel, width, height,
>  			      burst_size, rot_mode);
>  
> -	ipu_cpmem_set_axi_id(channel, 1);
> -

The IC IDMAC channels were set to AXI ID 1 to avoid starving the scanout
channels. AXI ID 0 is set to the highest QoS priority in imx6q_axi_init,
AXI ID 1 is set slightly lower for that reason. This should be kept for
all the non-plus models.

>  	ipu_idmac_set_double_buffer(channel, ctx->double_buffering);
>  }
>  

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel