Re: [PATCH 15/18] scsi: storvsc: Initialize driver-private command before using it

From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hch@lst.de" <hch@lst.de>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>,
	"hare@suse.com" <hare@suse.com>,
	"kys@microsoft.com" <kys@microsoft.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"longli@microsoft.com" <longli@microsoft.com>
Subject: Re: [PATCH 15/18] scsi: storvsc: Initialize driver-private command before using it
Date: Mon, 22 May 2017 17:15:37 +0000	[thread overview]
Message-ID: <1495473336.1017.1.camel@sandisk.com> (raw)
In-Reply-To: <20170521065134.GF12891@lst.de>

On Sun, 2017-05-21 at 08:51 +0200, Christoph Hellwig wrote:
> On Fri, May 19, 2017 at 11:30:13AM -0700, Bart Van Assche wrote:
> > The storvsc driver is the only SCSI LLD that uses driver-private
> > command data and that does not zero-initialize that data before
> > reading it. Make this driver consistent with the other SCSI LLDs
> > that use driver-private command data.
> 
> Well.  Either we add zeroing to storvsc and remove it from common
> code, or we remove the zeroing from the drivers.
> 
> We shouldn't do both.  Given that we already zero the remaining
> command it seems to me like keeping the zeroing in common code
> would be preferred, but I'm open to discussion.

Hello Christoph,

I will remove the code that zeroes driver-private command data from the other
SCSI LLDs and add it to the scsi-sq request preparation code path.

Bart.