From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: "Ian Jackson" <Ian.Jackson@eu.citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [OSSTEST PATCH 2/2] ts-hosts-allocate-Executive: Make build failures not be host-sticky
Date: Thu, 25 May 2017 12:51:07 +0100 [thread overview]
Message-ID: <1495713067-19757-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1495713067-19757-1-git-send-email-ian.jackson@eu.citrix.com>
Builds (jobs whose recipe contains `build') are not supposed to
contain host-specific tests. We already don't care about varying
which host they run on, to hunt for host-specific bugs.
We should also not make build failures sticky to the host they last
failed on.
Fix this by defaulting $prevfail_bonus to 0 in that case, before the
week-long later default is applied. This means that a build job
runvar would override the built-in default whether that's 7 days or 0.
Reported-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
ts-hosts-allocate-Executive | 1 +
1 file changed, 1 insertion(+)
diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive
index 7494291..975a8b9 100755
--- a/ts-hosts-allocate-Executive
+++ b/ts-hosts-allocate-Executive
@@ -624,6 +624,7 @@ sub hid_recurse ($$) {
if ($jobinfo->{recipe} =~ m/build/) {
$variation_age= 0;
$duration_for_cost= $duration + $duration_rightaway_adjust;
+ $prevfail_bonus //= 0;
}
my $log_variation_age = log(1+$variation_age/86400);
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-25 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 11:51 [OSSTEST PATCH 1/2] ts-hosts-allocate-Executive: Move $prevfail_bonus initial setting Ian Jackson
2017-05-25 11:51 ` Ian Jackson [this message]
2017-05-26 8:50 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495713067-19757-2-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.