Re: [PATCH] HID: Add driver for Retrode2 joypad adapter

From: Bastien Nocera <hadess@hadess.net>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: Add driver for Retrode2 joypad adapter
Date: Wed, 07 Jun 2017 17:42:53 +0200	[thread overview]
Message-ID: <1496850173.11482.7.camel@hadess.net> (raw)
In-Reply-To: <20170607142858.GF16591@mail.corp.redhat.com>

On Wed, 2017-06-07 at 16:28 +0200, Benjamin Tissoires wrote:
> On Jun 07 2017 or thereabouts, Bastien Nocera wrote:
<snip>
> > +		hid_err(hdev, "parse failed\n");
> 
> This error message is probably too much, just return in case of
> failure,
> we will get an error if something wrong happens.
> 
> > +		return ret;
> > +	}
> > +
> > +	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
> > +	if (ret) {
> > +		hid_err(hdev, "hw start failed\n");
> 
> Same here.

Both fixed.

> > +static const struct hid_device_id retrode_devices[] = {
> > +	{ HID_USB_DEVICE(USB_VENDOR_ID_FUTURE_TECHNOLOGY,
> > USB_DEVICE_ID_RETRODE2) },
> 
> Aren't you missing the same entry in hid-core.c
> hid_have_special_driver?

I guess I am, fixed.