From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "mchristi@redhat.com" <mchristi@redhat.com>,
"lixiubo@cmss.chinamobile.com" <lixiubo@cmss.chinamobile.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"bryantly@linux.vnet.ibm.com" <bryantly@linux.vnet.ibm.com>
Subject: Re: [PATCH] tcmu: Fix possbile memory leak when recalculating the cmd base size
Date: Tue, 11 Jul 2017 02:34:14 -0700 [thread overview]
Message-ID: <1499765654.28145.59.camel@haakon3.daterainc.com> (raw)
In-Reply-To: <1499765039.16582.3.camel@wdc.com>
On Tue, 2017-07-11 at 09:24 +0000, Damien Le Moal wrote:
> Xiubo,
>
> Well done ! This fixed my problem. The ZBC test suite now passes all tests on
> my target without crashing the kernel.
>
> Please see some comments/nitpicks below.
>
> Otherwise, please feel free to add my "tested-by"
>
Great, thanks for the quick turn-around.
Xiubo, please pick-up Damien's extra bits and repost for v2. Also,
please update the patch topic + commit log to mention it addresses a
general protection fault OOPs, so others can find it easily when looking
through git log.
Damien's OOPs would probably be the best one to include in the commit
log, since Bryant's was on POWER. ;)
Btw, since it's a regression fix related to commit fe25cc34795, I assume
it should be CC'ed to stable for v4.12.y, right..?
next prev parent reply other threads:[~2017-07-11 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 8:05 [PATCH] tcmu: Fix possbile memory leak when recalculating the cmd base size lixiubo
2017-07-11 9:06 ` Xiubo Li
2017-07-11 9:24 ` Damien Le Moal
2017-07-11 9:33 ` [PATCH] tcmu: Fix possbile memory leak when recalculating the cmdbase size Xiubo Li
2017-07-11 9:34 ` Nicholas A. Bellinger [this message]
2017-07-11 9:37 ` [PATCH] tcmu: Fix possbile memory leak when recalculating thecmd base size Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499765654.28145.59.camel@haakon3.daterainc.com \
--to=nab@linux-iscsi.org \
--cc=Damien.LeMoal@wdc.com \
--cc=bryantly@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
--cc=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.