Re: [PATCH v7 2/6] xen/x86: move generically usable NUMA code from x86 to common

From: Jan Beulich <jbeulich@suse.com>
To: Wei Chen <Wei.Chen@arm.com>
Cc: nd <nd@arm.com>, "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
	"George Dunlap" <george.dunlap@citrix.com>,
	"Julien Grall" <julien@xen.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v7 2/6] xen/x86: move generically usable NUMA code from x86 to common
Date: Mon, 7 Nov 2022 11:14:25 +0100	[thread overview]
Message-ID: <14e5a51b-2c22-7bef-fb9a-e10f7f71f25d@suse.com> (raw)
In-Reply-To: <PAXPR08MB7420FB5EE6A3A8990894563A9E3C9@PAXPR08MB7420.eurprd08.prod.outlook.com>

On 07.11.2022 11:09, Wei Chen wrote:
> Hi Jan,
> 
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: 2022年11月3日 22:26
>> To: Wei Chen <Wei.Chen@arm.com>
>> Cc: nd <nd@arm.com>; Andrew Cooper <andrew.cooper3@citrix.com>; Roger Pau
>> Monné <roger.pau@citrix.com>; Wei Liu <wl@xen.org>; George Dunlap
>> <george.dunlap@citrix.com>; Julien Grall <julien@xen.org>; Stefano
>> Stabellini <sstabellini@kernel.org>; xen-devel@lists.xenproject.org
>> Subject: Re: [PATCH v7 2/6] xen/x86: move generically usable NUMA code
>> from x86 to common
>>
>> On 20.10.2022 08:14, Wei Chen wrote:
>>> There are some codes in x86/numa.c can be shared by common
>>> architectures to implememnt NUMA support. Just like some
>>> variables and functions to check and store NUMA memory map.
>>> And some variables and functions to do NUMA initialization.
>>>
>>> In this patch, we move them to common/numa.c and xen/numa.h
>>> and use the CONFIG_NUMA to gate them for non-NUMA supported
>>> architectures. As the target header file is Xen-style, so
>>> we trim some spaces and replace tabs for the codes that has
>>> been moved to xen/numa.h at the same time.
>>>
>>> As acpi_scan_nodes has been used in a common function, it
>>> doesn't make sense to use acpi_xxx in common code, so we
>>> rename it to numa_process_nodes in this patch too. After that
>>> if we still use CONFIG_ACPI_NUMA in to gate numa_process_nodes
>>> in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA
>>> will be selected by CONFIG_ACPI_NUMA for x86. So, we replace
>>> CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_process_nodes.
>>>
>>> As arch_numa_disabled has been implememnted for ACPI NUMA,
>>> we can rename srat_disabled to numa_disabled and move it
>>> to common code as well.
>>>
>>> The macro node_to_first_cpu(node) hasn't been used anywhere,
>>> so we drop it in this patch too.
>>>
>>> Because some architectures allow to use all 64 physical address
>>> bits, but some architectures are not (like Arm64 allows 52, 48
>>> bits). In this case, we use min(PADDR_BITS, BITS_PER_LONG - 1)
>>> to calculate the shift when only one node is in the system in
>>> this patch too.
>>>
>>> Signed-off-by: Wei Chen <wei.chen@arm.com>
>>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> with one small further request (could be taken care of also while
>> committing if no other need for a v8 arises):
>>
> 
> Thanks. This series is in merge conflict status now, do I need to
> send a v8 to fix the merge conflict?

Generally yes. While committers _may_ be willing to fix up conflicts,
strictly speaking the committer role ought to be a purely mechanical
one, i.e. not touching patches at all.

> If yes, I will fix above as well, after PATCH#5 be reviewed.

And I've been meaning to get to that one ... Then again this series
can't be committed anyway before 4.17 was branched off.

Jan