From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 04/14] scsi: core: Pick suitable allocation length in scsi_report_opcode()
Date: Wed, 20 Apr 2022 14:06:47 +0200 [thread overview]
Message-ID: <14ecedfb-a965-5862-2aff-2ea319059366@suse.de> (raw)
In-Reply-To: <20220302053559.32147-5-martin.petersen@oracle.com>
On 3/2/22 06:35, Martin K. Petersen wrote:
> Some devices hang when a buffer size larger than expected is passed in
> the ALLOCATION LENGTH field. For REPORT SUPPORTED OPERATION CODES we
> currently only request a single command descriptor at a time and
> therefore the actual size of the command is known ahead of time. Limit
> the ALLOCATION LENGTH to the header size plus the command length of
> the opcode we are asking about.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> ---
> drivers/scsi/scsi.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2022-04-20 12:06 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 5:35 SCSI discovery update Martin K. Petersen
2022-03-02 5:35 ` [PATCH 01/14] scsi: mpt3sas: Use cached ATA Information VPD page Martin K. Petersen
2022-03-02 9:47 ` Christoph Hellwig
2022-03-02 14:18 ` Johannes Thumshirn
2022-04-20 12:06 ` Hannes Reinecke
2022-05-03 0:51 ` Martin K. Petersen
2022-03-02 5:35 ` [PATCH 02/14] scsi: core: Query VPD size before getting full page Martin K. Petersen
2022-03-02 9:48 ` Christoph Hellwig
2022-03-02 14:25 ` Johannes Thumshirn
2022-03-04 3:42 ` Martin K. Petersen
2022-03-03 0:30 ` Bart Van Assche
2022-03-04 3:28 ` Martin K. Petersen
2022-03-02 5:35 ` [PATCH 03/14] scsi: core: Do not truncate INQUIRY data on modern devices Martin K. Petersen
2022-03-02 9:49 ` Christoph Hellwig
2022-03-02 14:27 ` Johannes Thumshirn
2022-03-03 0:14 ` Bart Van Assche
2022-03-04 3:40 ` Martin K. Petersen
2022-03-02 5:35 ` [PATCH 04/14] scsi: core: Pick suitable allocation length in scsi_report_opcode() Martin K. Petersen
2022-03-02 9:49 ` Christoph Hellwig
2022-03-02 14:29 ` Johannes Thumshirn
2022-03-03 0:39 ` Bart Van Assche
2022-04-20 12:06 ` Hannes Reinecke [this message]
2022-03-02 5:35 ` [PATCH 05/14] scsi: core: Cache VPD pages b0, b1, b2 Martin K. Petersen
2022-03-02 9:50 ` Christoph Hellwig
2022-03-02 14:30 ` Johannes Thumshirn
2022-03-03 1:30 ` Bart Van Assche
2022-04-20 12:07 ` Hannes Reinecke
2022-03-02 5:35 ` [PATCH 06/14] scsi: sd: Use cached ATA Information VPD page Martin K. Petersen
2022-03-02 9:50 ` Christoph Hellwig
2022-03-03 0:40 ` Bart Van Assche
2022-03-04 9:29 ` Johannes Thumshirn
2022-03-02 5:35 ` [PATCH 07/14] scsi: sd: Switch to using scsi_device VPD pages Martin K. Petersen
2022-03-02 9:51 ` Christoph Hellwig
2022-03-03 0:42 ` Bart Van Assche
2022-03-04 9:29 ` Johannes Thumshirn
2022-03-02 5:35 ` [PATCH 08/14] scsi: sd: Optimal I/O size should be a multiple of reported granularity Martin K. Petersen
2022-03-02 9:51 ` Christoph Hellwig
2022-03-03 20:17 ` Bart Van Assche
2022-03-04 3:45 ` Martin K. Petersen
2022-03-04 5:06 ` Bart Van Assche
2022-03-02 5:35 ` [PATCH 09/14] scsi: sd: Fix discard errors during revalidate Martin K. Petersen
2022-03-02 9:52 ` Christoph Hellwig
2022-03-03 21:06 ` Bart Van Assche
2022-03-04 3:55 ` Martin K. Petersen
2022-03-06 0:35 ` Bart Van Assche
2022-03-02 5:35 ` [PATCH 10/14] scsi: sd: Move WRITE_ZEROES configuration to a separate function Martin K. Petersen
2022-03-02 9:53 ` Christoph Hellwig
2022-03-03 0:52 ` Bart Van Assche
2022-07-18 16:51 ` regression next-20220714: mkfs.ext4 on multipath device over scsi disks causes 'lifelock' in block layer Benjamin Block
2022-07-19 2:23 ` Martin K. Petersen
2022-07-19 11:37 ` Benjamin Block
2022-07-21 2:29 ` Martin K. Petersen
2022-07-21 13:25 ` Benjamin Block
2022-03-02 5:35 ` [PATCH 11/14] scsi: sd: Implement support for NDOB flag in WRITE SAME(16) Martin K. Petersen
2022-03-02 9:54 ` Christoph Hellwig
2022-03-03 1:29 ` Bart Van Assche
2022-03-04 9:32 ` Johannes Thumshirn
2022-03-02 5:35 ` [PATCH 12/14] scsi: sd: sd_read_cpr() requires VPD pages Martin K. Petersen
2022-03-02 9:54 ` Christoph Hellwig
2022-03-02 10:45 ` Damien Le Moal
2022-04-06 1:29 ` Damien Le Moal
2022-04-07 2:19 ` Martin K. Petersen
2022-04-07 2:36 ` Damien Le Moal
2022-04-07 2:48 ` Martin K. Petersen
2022-03-03 20:13 ` Bart Van Assche
2022-03-04 9:33 ` Johannes Thumshirn
2022-03-02 5:35 ` [PATCH 13/14] scsi: sd: Reorganize DIF/DIX code to avoid calling revalidate twice Martin K. Petersen
2022-03-02 9:57 ` Christoph Hellwig
2022-03-04 9:36 ` Johannes Thumshirn
2022-03-02 5:35 ` [PATCH 14/14] scsi: sd: Enable modern protocol features on more devices Martin K. Petersen
2022-03-02 9:58 ` Christoph Hellwig
2022-03-03 1:25 ` Bart Van Assche
2022-03-04 9:38 ` Johannes Thumshirn
2022-03-03 6:09 ` SCSI discovery update Douglas Gilbert
2022-03-04 3:26 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14ecedfb-a965-5862-2aff-2ea319059366@suse.de \
--to=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.